[webkit-changes] [WebKit/WebKit] 0d2c1b: [WebGPU] WebGPU: RemoteBuffer::getMappedRange() se...

mwyrzykowski noreply at github.com
Wed Mar 20 07:38:37 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d2c1bf775f993e9f392f00216b08325ee9671b2
      https://github.com/WebKit/WebKit/commit/0d2c1bf775f993e9f392f00216b08325ee9671b2
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp

  Log Message:
  -----------
  [WebGPU] WebGPU: RemoteBuffer::getMappedRange() sets Write flag unconditionally
https://bugs.webkit.org/show_bug.cgi?id=271266
<radar://124995553>

Reviewed by Dan Glastonbury.

We should only set the map mode to Write if the buffer was
mapped at creation, otherwise we can write to a buffer that was
mapped as read only.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp:
(WebKit::RemoteBuffer::RemoteBuffer):
(WebKit::RemoteBuffer::getMappedRange):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp:
(WebKit::WebGPU::RemoteBufferProxy::RemoteBufferProxy):
(WebKit::WebGPU::RemoteBufferProxy::getMappedRange):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::createBuffer):

Canonical link: https://commits.webkit.org/276405@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list