[webkit-changes] [WebKit/WebKit] 983282: [IFC][Ruby] Line spacing is not even for contents ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 983282c29f7dceda11aef7f77a54a0d997f0892a
      https://github.com/WebKit/WebKit/commit/983282c29f7dceda11aef7f77a54a0d997f0892a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    A LayoutTests/fast/ruby/tight-line-spacing-with-line-height-expected.html
    A LayoutTests/fast/ruby/tight-line-spacing-with-line-height.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp

  Log Message:
  -----------
  [IFC][Ruby] Line spacing is not even for contents that has ruby
https://bugs.webkit.org/show_bug.cgi?id=271295
<rdar://122436686>

Reviewed by Antti Koivisto.

Let annotation spill into previous/next line's half-leading to keep vertical (horizontal) rhythm (i.e. do not stretch lines with ruby too much even if it means overlapping adjacent line boxes).

* LayoutTests/fast/ruby/tight-line-spacing-with-line-height-expected.html: Added.
* LayoutTests/fast/ruby/tight-line-spacing-with-line-height.html: Added.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase):

Canonical link: https://commits.webkit.org/276402@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications