[webkit-changes] [WebKit/WebKit] 129ce1: AXNotification enum ought to be an X macro

Ross Kirsling noreply at github.com
Wed Mar 20 00:42:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 129ce14b05a4a086cd7ddb915f9ad64c116873aa
      https://github.com/WebKit/WebKit/commit/129ce14b05a4a086cd7ddb915f9ad64c116873aa
  Author: Ross Kirsling <ross.kirsling at sony.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  AXNotification enum ought to be an X macro
https://bugs.webkit.org/show_bug.cgi?id=270893

Reviewed by Darin Adler.

AXNotification is a giant and frequently updated enum.
Every time it is updated, exhaustive switch statements must be updated accordingly.

This is a very appropriate place for an X macro --
selfishly, it will help PlayStation port avoid build breaks (since we handle this enum in WKAPICast),
but irrespective of platform, it also means that AXLogger won't need to be updated each time AXNotification is updated.

* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/276393@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list