[webkit-changes] [WebKit/WebKit] cc094b: Use connection instead of mainFrameOrOpenerDomain ...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc094b8fd290a9d342b4abd87e8e7effc6e4b575
      https://github.com/WebKit/WebKit/commit/cc094b8fd290a9d342b4abd87e8e7effc6e4b575
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
    M Source/WebKit/UIProcess/BrowsingContextGroup.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  -----------
  Use connection instead of mainFrameOrOpenerDomain when deciding what process to use for site isolated window.open
https://bugs.webkit.org/show_bug.cgi?id=271280
rdar://125044857

Reviewed by Charlie Wolfe.

This is the first of at least 2 steps to get http/tests/site-isolation/iframe-and-window-open.html to not assert
when run with --site-isolation.  The other is to make WebProcessPool::createWebPage not assume that the opened page's
main frame needs to start in the same process as the opener's main frame process because window.open can be called
from iframes.

* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::processForConnection):
(WebKit::BrowsingContextGroup::addPage):
* Source/WebKit/UIProcess/BrowsingContextGroup.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::mainFrameOrOpenerDomain const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage):

Canonical link: https://commits.webkit.org/276384@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications