[webkit-changes] [WebKit/WebKit] 80b0cc: [WebAuthn] Unable to submit new requests after can...

Commit Queue noreply at github.com
Tue Mar 19 14:52:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80b0cc5927c72554468e135fcdd28fb6a7316f51
      https://github.com/WebKit/WebKit/commit/80b0cc5927c72554468e135fcdd28fb6a7316f51
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp

  Log Message:
  -----------
  [WebAuthn] Unable to submit new requests after cancelling conditional mediation via abortSignal
rdar://124727713
https://bugs.webkit.org/show_bug.cgi?id=271257

Reviewed by Charlie Wolfe.

In https://bugs.webkit.org/show_bug.cgi?id=257176, functionality was introduced to wait for a
previous request's cancel to complete before submitting a subsequent one. However, there's currently
a bug that does not set the cancel flag to false if there's no subsequent request.

This patch fixes that bug by setting m_isCancelling to false once the cancel completes regardless of
if there's a subsequent request.

* Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource):

Canonical link: https://commits.webkit.org/276368@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list