[webkit-changes] [WebKit/WebKit] 29536a: Build scripts should default to the Internal works...

Keith Miller noreply at github.com
Tue Mar 19 14:07:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29536a50b549dd94eaa0f0f6c6a60e364a62dee5
      https://github.com/WebKit/WebKit/commit/29536a50b549dd94eaa0f0f6c6a60e364a62dee5
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm
    M Tools/Scripts/webkitperl/BuildSubproject.pm

  Log Message:
  -----------
  Build scripts should default to the Internal workspace using the internal SDK
https://bugs.webkit.org/show_bug.cgi?id=271245
rdar://125015308

Reviewed by Elliott Williams.

Right now in order to get WebKitAdditions when using these scripts you have to already have started a build
from Internal. This is annoying for clean builds or when WebKitBuild has a stale WebKitAdditions. This patch
changes the build scripts to default to the Internal workspace when building for a .internal SDK and the
regular workspace when building for a public SDK. If there's already a configured workspace then we just
use that.

* Tools/Scripts/webkitdirs.pm:
(determineConfiguredXcodeWorkspaceOrDefault):
(configuredXcodeWorkspace):
(XcodeOptions):
(determineConfiguredXcodeWorkspace): Deleted.
* Tools/Scripts/webkitperl/BuildSubproject.pm:
(buildUpToProject):

Canonical link: https://commits.webkit.org/276366@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list