[webkit-changes] [WebKit/WebKit] 3cc63f: Web Inspector: FolderizedTreeElement doesn't need ...

Qianlang Chen noreply at github.com
Tue Mar 19 11:29:29 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cc63f452ee1f7b27315942d53543c6dd041dfb9
      https://github.com/WebKit/WebKit/commit/3cc63f452ee1f7b27315942d53543c6dd041dfb9
  Author: Qianlang Chen <qianlangchen at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js

  Log Message:
  -----------
  Web Inspector: FolderizedTreeElement doesn't need to remember expansion states anymore since FolderTreeElement already does the job
rdar://124158713
https://bugs.webkit.org/show_bug.cgi?id=270595

Reviewed by Devin Rousso.

Remove the creating and handling of expansion states from
FolderizedTreeElement.

* Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js:
(WI.FolderizedTreeElement):
(WI.FolderizedTreeElement.prototype.removeChildren):
- No need anymore for remembering the WI.Setting items for each created
  child FolderTreeElement.

(WI.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
- Passing the folderId into the created child FolderTreeElement will
  make it do the state-remembering job.

(WI.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange): Deleted.
- The child FolderTreeElement already does this job.

Canonical link: https://commits.webkit.org/276357@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list