[webkit-changes] [WebKit/WebKit] dd766a: Make NetworkStorageSession::nsCookieStorage() retu...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd766a3312d0b3fc4f858951893ad75fc7b640f3
      https://github.com/WebKit/WebKit/commit/dd766a3312d0b3fc4f858951893ad75fc7b640f3
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
    M Source/WebKit/NetworkProcess/Cookies/mac/WebCookieManagerMac.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm

  Log Message:
  -----------
  Make NetworkStorageSession::nsCookieStorage() return RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=271222
rdar://117317285

Reviewed by Chris Dumez.

To avoid the returned NSHTTPCookieStorage being released while it's still in use.

* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::hasCookies const):
(WebCore::NetworkStorageSession::setAllCookiesToSameSiteStrict):
(WebCore::NetworkStorageSession::nsCookieStorage const):
(WebCore::NetworkStorageSession::cookieStorageObserver const):
* Source/WebKit/NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformFlushCookies):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::unblockCookies):

Canonical link: https://commits.webkit.org/276355@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications