[webkit-changes] [WebKit/WebKit] c3a017: [GTK] Failed to create GBM buffer of size 0x0: Inv...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3a01735d06427eafeffe86bef0c139eddb7f3c4
      https://github.com/WebKit/WebKit/commit/c3a01735d06427eafeffe86bef0c139eddb7f3c4
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  -----------
  [GTK] Failed to create GBM buffer of size 0x0: Invalid argument
https://bugs.webkit.org/show_bug.cgi?id=265154

Reviewed by Michael Catanzaro.

This happens because in some cases we schedule a layer flush before the
drawing area size is initially updated. It's easier to happen in the
case of inspector because we don't delay the web process creation until
the first load in that case. We should just ignore layer flush requests
when the view size is empty since we won't be able to render anything
anyway. Also set the device scale factor before the page is initialized
to avoid sending an IPC message right after web page creation.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::scheduleLayerFlush):

Canonical link: https://commits.webkit.org/276337@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications