[webkit-changes] [WebKit/WebKit] e37f46: model tag should inherit background color CSS

[eddydas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e37f4682210fbdca364bf9374911860e9a90b63a
      https://github.com/WebKit/WebKit/commit/e37f4682210fbdca364bf9374911860e9a90b63a
  Author: Eddy Wong <eddy_wong at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebCore/Modules/model-element/HTMLModelElement.h
    M Source/WebCore/Modules/model-element/ModelPlayer.cpp
    M Source/WebCore/Modules/model-element/ModelPlayer.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h

  Log Message:
  -----------
  model tag should inherit background color CSS
rdar://120927982
https://bugs.webkit.org/show_bug.cgi?id=270828

Reviewed by Tim Horton.

Propagate the resolved renderer background color for the model tag
into ModelProcessModelPlayerProxy for setting into the portal layer.

Background color will always be converted to opaque before being
applied to the portal layer. This is to prevent showing passthrough
through the page.

Invalid color will result in resetting the background color to white.

* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::applyBackgroundColor):
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/ModelPlayer.cpp:
(WebCore::ModelPlayer::setBackgroundColor):
* Source/WebCore/Modules/model-element/ModelPlayer.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::createLayer):
(WebKit::ModelProcessModelPlayerProxy::didFinishLoading):
(WebKit::ModelProcessModelPlayerProxy::setBackgroundColor):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::setBackgroundColor):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:

Canonical link: https://commits.webkit.org/276325@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications