[webkit-changes] [WebKit/WebKit] 292ff7: Crash under AccessibilityObject::accessibilitySecu...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 292ff7293a5c8f04400a7a37665a8ad1a02e9b5d
      https://github.com/WebKit/WebKit/commit/292ff7293a5c8f04400a7a37665a8ad1a02e9b5d
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

  Log Message:
  -----------
  Crash under AccessibilityObject::accessibilitySecureFieldLength()
https://bugs.webkit.org/show_bug.cgi?id=271158
rdar://122375537

Reviewed by Chris Dumez.

This patch removes this unchecked downcast and generally simplifies the
function. It has also been changed to return an unsigned, as it cannot
possibly return a negative value, and furthermore, HTMLInput::value()
returns a String, and the length() of Strings is unsigned.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilitySecureFieldLength):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityValue]):

Canonical link: https://commits.webkit.org/276320@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications