[webkit-changes] [WebKit/WebKit] c52386: UnifiedPDF: Find-in-page highlights very unstable ...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c52386bd6732a1e7c438508a47a44b639e919e3c
      https://github.com/WebKit/WebKit/commit/c52386bd6732a1e7c438508a47a44b639e919e3c
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/WebPage/FindController.cpp

  Log Message:
  -----------
  UnifiedPDF: Find-in-page highlights very unstable during zoom
https://bugs.webkit.org/show_bug.cgi?id=271177

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::setScaleFactor):
Adopt our `scrollToPoint` helper, which also makes this a programmatic scroll,
which is important to make its application synchronous in the Web Content process,
so that we can correctly repaint the overlay synchronously.

* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
Disable async scrolling for UnifiedPDFPlugin while the find overlay is installed.

Canonical link: https://commits.webkit.org/276316@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications