[webkit-changes] [WebKit/WebKit] e4bddd: [ Ventura WK1 ] 2x imported/w3c/web-platform-tests...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4bddd14467ff8e5f1537083fc5f58014c87ee95
      https://github.com/WebKit/WebKit/commit/e4bddd14467ff8e5f1537083fc5f58014c87ee95
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

  Log Message:
  -----------
  [ Ventura WK1 ] 2x imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-mode are constant crashes
https://bugs.webkit.org/show_bug.cgi?id=270915
rdar://124540415

Reviewed by Jer Noble.

WebKit crashes because an internal method called by
`-[AVPlayerItem selectMediaOption:inMediaSelectionGroup:]` messages a nil NSArray and an
ObjC exception  is thrown. Prevent the crash by putting all calls to
`-[AVPlayerItem selectMediaOption:inMediaSelectionGroup:]` in try/catch blocks.

* Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):

Canonical link: https://commits.webkit.org/276314@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications