[webkit-changes] [WebKit/WebKit] f342b3: [run-webkit-tests] Manager shouldn't treat all IOE...

Sam Sneddon noreply at github.com
Mon Mar 18 15:10:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f342b3fa9121a066f4662153f043e664e02408c9
      https://github.com/WebKit/WebKit/commit/f342b3fa9121a066f4662153f043e664e02408c9
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py
    M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

  Log Message:
  -----------
  [run-webkit-tests] Manager shouldn't treat all IOErrors invalid --test-list paths
https://bugs.webkit.org/show_bug.cgi?id=271180

Reviewed by Jonathan Bedard and Darin Adler.

Currently this means all IOErrors are swallowed by Manager, which is
awkward when we have an actual bug (rdar://124918090) here, which should
show up as an uncaught exception rather than silently failing.

* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:
(LayoutTestFinder._read_test_names_from_file):
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
(Manager.print_expectations):
(Manager.print_summary):

Canonical link: https://commits.webkit.org/276304@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list