[webkit-changes] [WebKit/WebKit] fee2d0: Unified PDF: HUD gets pinned to the left side of t...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fee2d02ccb2159f478000d7b9264ac55c21889ef
      https://github.com/WebKit/WebKit/commit/fee2d02ccb2159f478000d7b9264ac55c21889ef
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/PDF/WKPDFHUDView.h
    M Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm

  Log Message:
  -----------
  Unified PDF: HUD gets pinned to the left side of the viewport after dragging window from/to 1x display
https://bugs.webkit.org/show_bug.cgi?id=271170

Reviewed by Simon Fraser and Abrar Rahman Protyasha.

Fix a longstanding bug in the HUD: if the device scale factor changes but the
HUD frame does not, we'll rebuild the layer, but not lay it out inside the view,
only set its size.

Fix this by removing our setFrame override and implementing -layout instead.

* Source/WebKit/UIProcess/PDF/WKPDFHUDView.h:
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm:
(-[WKPDFHUDView layout]):
(-[WKPDFHUDView _setupLayer:]):
(-[WKPDFHUDView _redrawLayer]):
(-[WKPDFHUDView setFrame:]): Deleted.

Canonical link: https://commits.webkit.org/276289@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications