[webkit-changes] [WebKit/WebKit] ee7e9f: [Xcode] Simplify code coverage builds

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee7e9fa115013e7be28a5ba2f52c16f486d4e55a
      https://github.com/WebKit/WebKit/commit/ee7e9fa115013e7be28a5ba2f52c16f486d4e55a
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M Makefile.shared
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Tools/Scripts/webkitdirs.pm
    R Tools/coverage/coverage.xcconfig

  Log Message:
  -----------
  [Xcode] Simplify code coverage builds
https://bugs.webkit.org/show_bug.cgi?id=271055
<rdar://124086420>

Reviewed by Alex Christensen.

This change simplifies code coverage builds of WebKit using Xcode.
Instead of specifying `-xcconfig Tools/coverage/coverage.xcconfig` on
the command-line, the CLANG_COVERAGE_MAPPING=YES Xcode variable now
enables code coverage builds.

* Makefile.shared:
- Add support for `CODE_COVERAGE=YES` when using `make` to build.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
(WebCoreTestSupport: InternalSettingsGenerated.cpp):
- This file causes clang to hang indefinitely when compiled with code
  coverage enabled, so add
  "-fno-profile-instr-generate -fno-coverage-mapping" to COMPILER_FLAGS
  for just this file.  (Has no effect on non-code-coverage builds.)  The
  issue is tracked by <rdar://124640196>.
* Tools/Scripts/webkitdirs.pm:
(XcodeCoverageSupportOptions):
- Use "CLANG_COVERAGE_MAPPING=YES" instead of specifying a path to
  Tools/coverage/coverage.xcconfig.
* Tools/coverage/coverage.xcconfig: Remove.

Canonical link: https://commits.webkit.org/276273@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications