[webkit-changes] [WebKit/WebKit] 9ac555: [Legacy line layout removal] Remove hyphenation

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ac555f80a69415b0d9e2743ab50a5fda4487c0d
      https://github.com/WebKit/WebKit/commit/9ac555f80a69415b0d9e2743ab50a5fda4487c0d
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-16 (Sat, 16 Mar 2024)

  Changed paths:
    M Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h
    M Source/WebCore/platform/text/BidiResolver.h
    M Source/WebCore/rendering/BidiRun.cpp
    M Source/WebCore/rendering/LegacyInlineBox.cpp
    M Source/WebCore/rendering/LegacyInlineBox.h
    M Source/WebCore/rendering/LegacyInlineTextBox.cpp
    M Source/WebCore/rendering/LegacyInlineTextBox.h
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/LegacyLineLayout.h
    M Source/WebCore/rendering/LegacyRootInlineBox.cpp
    M Source/WebCore/rendering/LegacyRootInlineBox.h
    M Source/WebCore/rendering/line/BreakingContext.h
    M Source/WebCore/rendering/line/LineBreaker.cpp
    M Source/WebCore/rendering/line/LineBreaker.h

  Log Message:
  -----------
  [Legacy line layout removal] Remove hyphenation
https://bugs.webkit.org/show_bug.cgi?id=271106
rdar://problem/124730805

Reviewed by Alan Baradlay.

SVG does not hyphenate, or break lines in general.

* Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::hasHyphen const):
(WebCore::InlineIterator::BoxLegacyPath::textRun const):
* Source/WebCore/platform/text/BidiResolver.h:
* Source/WebCore/rendering/BidiRun.cpp:
(WebCore::BidiRun::BidiRun):
* Source/WebCore/rendering/LegacyInlineBox.cpp:
(WebCore::LegacyInlineBox::logicalHeight const):
(WebCore::LegacyInlineBox::adjustPosition):
* Source/WebCore/rendering/LegacyInlineBox.h:
(WebCore::LegacyInlineBox::InlineBoxBitfields::InlineBoxBitfields):
(WebCore::LegacyInlineBox::setExpansion): Deleted.
(WebCore::LegacyInlineBox::setExpansionWithoutGrowing): Deleted.
(WebCore::LegacyInlineBox::expansion const): Deleted.
(WebCore::LegacyInlineBox::setHasHyphen): Deleted.
(WebCore::LegacyInlineBox::setCanHaveLeftExpansion): Deleted.
(WebCore::LegacyInlineBox::setCanHaveRightExpansion): Deleted.
(WebCore::LegacyInlineBox::setForceRightExpansion): Deleted.
(WebCore::LegacyInlineBox::setForceLeftExpansion): Deleted.
(WebCore::LegacyInlineBox::hasHyphen const): Deleted.
(WebCore::LegacyInlineBox::canHaveLeftExpansion const): Deleted.
(WebCore::LegacyInlineBox::canHaveRightExpansion const): Deleted.
(WebCore::LegacyInlineBox::forceRightExpansion const): Deleted.
(WebCore::LegacyInlineBox::forceLeftExpansion const): Deleted.

Also remove some other unused leftovers.

* Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::selectableRange const):
(WebCore::LegacyInlineTextBox::createTextRun const):
(WebCore::LegacyInlineTextBox::text const):
(WebCore::LegacyInlineTextBox::expansionBehavior const): Deleted.
* Source/WebCore/rendering/LegacyInlineTextBox.h:
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::constructLine):
(WebCore::LegacyLineLayout::layoutRunsAndFloats):
(WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange):
* Source/WebCore/rendering/LegacyLineLayout.h:
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::isHyphenated const): Deleted.
* Source/WebCore/rendering/LegacyRootInlineBox.h:
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::handleBR): Deleted.
(WebCore::BreakingContext::handleOutOfFlowPositioned): Deleted.
(WebCore::BreakingContext::handleReplaced): Deleted.
(WebCore::measureHyphenWidth): Deleted.
(WebCore::tryHyphenating): Deleted.
* Source/WebCore/rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::nextLineBreak):
(WebCore::LineBreaker::reset): Deleted.
* Source/WebCore/rendering/line/LineBreaker.h:
(WebCore::LineBreaker::LineBreaker):
(WebCore::LineBreaker::lineWasHyphenated): Deleted.

Canonical link: https://commits.webkit.org/276241@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications