[webkit-changes] [WebKit/WebKit] 6e7fff: Skip gb18030 table correction on platforms with IC...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e7fffdeac955986ee20f2a860d754e7f494ec00
      https://github.com/WebKit/WebKit/commit/6e7fffdeac955986ee20f2a860d754e7f494ec00
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/text/EncodingTables.cpp

  Log Message:
  -----------
  Skip gb18030 table correction on platforms with ICU 74
https://bugs.webkit.org/show_bug.cgi?id=271101
rdar://124720057

Reviewed by Yusuke Suzuki.

On the Sonoma 23E214 build released last week, ICU 74 is present as indicated by
the updated gb18030 table.  However, uvernum.h is not in the public SDK so open
source builds use the definition of U_ICU_VERSION_MAJOR_NUM in our copy of uvernum.h
in Source/WTF/icu/unicode/uvernum.h which has U_ICU_VERSION_MAJOR_NUM defined to 70.
Change the compile check to a runtime check.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/text/EncodingTables.cpp:
(PAL::gb18030):

Canonical link: https://commits.webkit.org/276229@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications