[webkit-changes] [WebKit/WebKit] bc6637: AX: VoiceOver doesn't speak the value of the merid...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc6637d9eddb9998679faae94a282db353bcec00
      https://github.com/WebKit/WebKit/commit/bc6637d9eddb9998679faae94a282db353bcec00
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    A LayoutTests/accessibility/datetime/time-input-meridiem-expected.txt
    A LayoutTests/accessibility/datetime/time-input-meridiem.html
    M Source/WebCore/html/shadow/DateTimeFieldElements.cpp
    M Source/WebCore/html/shadow/DateTimeFieldElements.h
    M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h

  Log Message:
  -----------
  AX: VoiceOver doesn't speak the value of the meridiem component in time controls.
https://bugs.webkit.org/show_bug.cgi?id=270243
rdar://problem/123781149

Reviewed by Chris Fleizach.

This patch makes the meridiem field a spinbutton and adds the
appropriate ARIA attributes so assistive technologies announce its
value.

* LayoutTests/accessibility/datetime/time-input-meridiem-expected.txt: Added.
* LayoutTests/accessibility/datetime/time-input-meridiem.html: Added.
* Source/WebCore/html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::updateAriaValueAttributes):
(WebCore::DateTimeMeridiemFieldElement::setValueAsDate):
(WebCore::DateTimeMeridiemFieldElement::setValueAsInteger):
(WebCore::DateTimeMeridiemFieldElement::setEmptyValue):
* Source/WebCore/html/shadow/DateTimeFieldElements.h:
* Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::AXTimeFieldMeridiemText): Deleted.
* Source/WebCore/platform/LocalizedStrings.h:

Canonical link: https://commits.webkit.org/276195@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications