[webkit-changes] [WebKit/WebKit] 6f20a0: Make WebAuthn interface easier to call from Swift

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f20a053abaf3366ff82a0fff43fb4d61e24cc46
      https://github.com/WebKit/WebKit/commit/6f20a053abaf3366ff82a0fff43fb4d61e24cc46
  Author: Garrett Davidson <garrett_davidson at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponse.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h

  Log Message:
  -----------
  Make WebAuthn interface easier to call from Swift
rdar://124490616

Reviewed by Brent Fulgham.

This patch updates a few bits from the WebAuthn interface to make them easier to call from
Swift.

* Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponse.mm:
(-[_WKAuthenticatorAssertionResponse initWithClientDataJSON:rawId:extensions:authenticatorData:signature:userHandle:attachment:]):
(-[_WKAuthenticatorAssertionResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:authenticatorData:signature:userHandle:attachment:]):
(-[_WKAuthenticatorAssertionResponse dealloc]):
None of the ivars in this class were being retained/released. This hasn't been an issue
for ObjC because they're all retained by the callsite, but it matters for Swift due to the
bridging between Data and NSData. The superclass already retains/releases its ivars
correctly.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
All of the results in these completion handlers are nullable (e.g. we never expect to
return an assertion _and_ an error). ObjC doesn't care if they're annotated incorrectly,
but Swift does.

Canonical link: https://commits.webkit.org/276180@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications