[webkit-changes] [WebKit/WebKit] da1ba7: Cherry-pick 274711 at main (2d4541ef3929). https://bu...

Fri Mar 15 08:15:51 PDT 2024

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: da1ba746a7134f08f043d6ececdef186c70ce08b
      https://github.com/WebKit/WebKit/commit/da1ba746a7134f08f043d6ececdef186c70ce08b
  Author: Olivier Blin <olivier.blin at softathome.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/glib/UserAgentQuirks.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

  Log Message:
  -----------
  Cherry-pick 274711 at main (2d4541ef3929). https://bugs.webkit.org/show_bug.cgi?id=269211

    Scope the UA override to www.apple.com/apple-events
    https://bugs.webkit.org/show_bug.cgi?id=269211

    Reviewed by Michael Catanzaro.

    A quirk has been introduced in 265206 at main (e0b0d3b7983f) to use a
    Chrome user-agent override for apple.com. Limit this to www.apple.com,
    so that it does not apply to tv.apple.com (and its custom subdomains).

    Otherwise, custom user-agents can not be used for Apple TV+ (rdar://122408473).

    https://apple.com/apple-events/ redirects to
    https://www.apple.com/apple-events/, so the quirk will still apply to both.

    * Source/WebCore/platform/glib/UserAgentQuirks.cpp:
    (WebCore::urlRequiresChromeBrowser):
    * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
    (TestWebKitAPI::TEST):

    Canonical link: https://commits.webkit.org/274711@main


  Commit: b733bab2be690922e36e02a38e623558da2dd600
      https://github.com/WebKit/WebKit/commit/b733bab2be690922e36e02a38e623558da2dd600
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/glib/UserAgentQuirks.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

  Log Message:
  -----------
  Cherry-pick 275835 at main (1a9883acbbb0). https://bugs.webkit.org/show_bug.cgi?id=270438

    Atlassian Confluence blocks Epiphany's user agent
    https://bugs.webkit.org/show_bug.cgi?id=270438

    Reviewed by Philippe Normand.

    * Source/WebCore/platform/glib/UserAgentQuirks.cpp:
    (WebCore::urlRequiresMacintoshPlatform):
    * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
    (TestWebKitAPI::TEST):

    Canonical link: https://commits.webkit.org/275835@main


  Commit: f91ce858e1a0092408d7eeb7f03540c088b470d6
      https://github.com/WebKit/WebKit/commit/f91ce858e1a0092408d7eeb7f03540c088b470d6
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/JavaScriptCore/llint/LowLevelInterpreter.asm

  Log Message:
  -----------
  Cherry-pick 274796 at main (be51d0725a2c). https://bugs.webkit.org/show_bug.cgi?id=269534

    [JSC] Use offlineasm globl to ensure that all entries have alt_entry
    https://bugs.webkit.org/show_bug.cgi?id=269534
    rdar://122525586

    Reviewed by Justin Michaud.

    We found that vmEntryToCSSJIT and vmEntryToCSSJITAfter are not having alt_entry properly since it is not using offlineasm globl.
    This allowed LLInt code shuffled by linkers when alt_entry is used, which breaks many assumptions. This patch fixes it.

    * Source/JavaScriptCore/llint/LowLevelInterpreter.asm:

    Canonical link: https://commits.webkit.org/274796@main


  Commit: 02645019fb735e5a609d1ba1d81d4ef409f9a565
      https://github.com/WebKit/WebKit/commit/02645019fb735e5a609d1ba1d81d4ef409f9a565
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/failure.html
    M LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js
    M LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.worker-expected.txt
    M Source/WTF/wtf/URLParser.cpp
    M Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp

  Log Message:
  -----------
  Cherry-pick 274915 at main (953476de5074). https://bugs.webkit.org/show_bug.cgi?id=265484

    URLParser should parse URLs including authority and a backslash after the host
    https://bugs.webkit.org/show_bug.cgi?id=265484
    rdar://119219832

    Reviewed by Alex Christensen.

    Thanks to dave caruso for reporting and suggesting a fix.

    Tests are synchronized up to and including this PR:
    https://github.com/web-platform-tests/wpt/pull/44637

    * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/failure.html:
    * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.worker-expected.txt:
    * Source/WTF/wtf/URLParser.cpp:
    (WTF::URLParser::parse):
    * Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:
    (TestWebKitAPI::TEST_F):

    Canonical link: https://commits.webkit.org/274915@main


  Commit: 3705e6a6243be60a815b8a6ce5702d5d48b7cb81
      https://github.com/WebKit/WebKit/commit/3705e6a6243be60a815b8a6ce5702d5d48b7cb81
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
    M Source/WebCore/platform/sql/SQLiteDatabase.h
    M Source/WebCore/platform/sql/SQLiteTransaction.cpp
    M Source/WebCore/platform/sql/SQLiteTransaction.h

  Log Message:
  -----------
  Cherry-pick 269697 at main (9405d3e158f7). https://bugs.webkit.org/show_bug.cgi?id=263539

    Use a CheckedRef for SQLiteTransaction::m_db
    https://bugs.webkit.org/show_bug.cgi?id=263539
    rdar://117364281

    Reviewed by Sihui Liu and Chris Dumez.

    Also remove `CanMakeWeakPtr<SQLiteDatabase>` since it's not used.

    * Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:
    (WebCore::IDBServer::SQLiteIDBCursor::createSQLiteStatement):
    (WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindPreIndexStatementIfNecessary):
    (WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):
    * Source/WebCore/platform/sql/SQLiteDatabase.h:
    * Source/WebCore/platform/sql/SQLiteTransaction.cpp:
    (WebCore::SQLiteTransaction::begin):
    (WebCore::SQLiteTransaction::commit):
    (WebCore::SQLiteTransaction::rollback):
    (WebCore::SQLiteTransaction::stop):
    (WebCore::SQLiteTransaction::wasRolledBackBySqlite const):
    * Source/WebCore/platform/sql/SQLiteTransaction.h:
    (WebCore::SQLiteTransaction::database const):

    Canonical link: https://commits.webkit.org/269697@main


  Commit: 2e418314739dad5443dffb8fb7b550dcbef2e2ae
      https://github.com/WebKit/WebKit/commit/2e418314739dad5443dffb8fb7b550dcbef2e2ae
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/sql/SQLiteStatement.cpp
    M Source/WebCore/platform/sql/SQLiteStatement.h

  Log Message:
  -----------
  Cherry-pick 269737 at main (65310540fa63). https://bugs.webkit.org/show_bug.cgi?id=263597

    Use CheckedRef for SQLiteStatement::m_database
    https://bugs.webkit.org/show_bug.cgi?id=263597
    rdar://117422901

    Reviewed by Chris Dumez.

    To make it more safe to use.

    * Source/WebCore/platform/sql/SQLiteStatement.cpp:
    (WebCore::SQLiteStatement::SQLiteStatement):
    (WebCore::SQLiteStatement::~SQLiteStatement):
    (WebCore::SQLiteStatement::step):
    * Source/WebCore/platform/sql/SQLiteStatement.h:
    (WebCore::SQLiteStatement::database):

    Canonical link: https://commits.webkit.org/269737@main


  Commit: cbc47a8b350a819a3c72f9133c7778d74ed49b6b
      https://github.com/WebKit/WebKit/commit/cbc47a8b350a819a3c72f9133c7778d74ed49b6b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/sql/SQLiteDatabase.h
    M Source/WebCore/platform/sql/SQLiteTransaction.h
    M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp

  Log Message:
  -----------
  Cherry-pick 274937 at main (f6305e2e3567). https://bugs.webkit.org/show_bug.cgi?id=269648

    Crash under SQLiteDatabase::~SQLiteDatabase
    https://bugs.webkit.org/show_bug.cgi?id=269648
    rdar://123160407

    Reviewed by David Kilzer.

    The crash was occurring because SQLiteStorageArea::handleDatabaseCorruptionIfNeeded()
    was destroying the SQLiteDatabase object (m_database) but was failing to destroy the
    potential transaction (m_transaction) and cached statements (m_cachedStatements), all
    of which have a CheckedRef pointing to the database.

    Update handleDatabaseCorruptionIfNeeded() to call close(), which clears m_cache,
    m_cacheSize, m_transaction, m_cachedStatements and m_database.

    Also update SQLiteStatement / SQLiteTransaction to keep a WeakRef to the database
    instead of a CheckedRef, as per our updated smart pointer guidelines. Using
    CheckedPtr/CheckedRef for database members is no longer recommended.

    * Source/WebCore/platform/sql/SQLiteDatabase.h:
    * Source/WebCore/platform/sql/SQLiteStatement.h:
    * Source/WebCore/platform/sql/SQLiteTransaction.h:
    * Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:
    (WebKit::SQLiteStorageArea::handleDatabaseCorruptionIfNeeded):

    Canonical link: https://commits.webkit.org/274937@main


  Commit: 873d58d60ecbc0a8ffd35d6fb426bc9206ccf96a
      https://github.com/WebKit/WebKit/commit/873d58d60ecbc0a8ffd35d6fb426bc9206ccf96a
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    A LayoutTests/fast/parser/badurl-base-preloader-crash-expected.txt
    A LayoutTests/fast/parser/badurl-base-preloader-crash.html
    A LayoutTests/http/tests/loading/preload-ignore-invalid-base-expected.txt
    A LayoutTests/http/tests/loading/preload-ignore-invalid-base.html
    A LayoutTests/http/tests/loading/resources/fail.js
    M Source/WebCore/html/parser/HTMLPreloadScanner.cpp

  Log Message:
  -----------
  Cherry-pick 274963 at main (393573035d7e). https://bugs.webkit.org/show_bug.cgi?id=269643

    HTMLPreloadScanner should only use valid `base` urls

    https://bugs.webkit.org/show_bug.cgi?id=269643

    Reviewed by Ryosuke Niwa.

    Partial Merge: https://chromium.googlesource.com/chromium/blink/+/754b22f62f6fa5f0b938a90c0e92502eb7f5a7c3

    Before this patch, HTMLPreloadScanner accepted invalid `base` urls and
    used it to resolve urls encountered later in the scan.
    This patch ensures that only valid urls specified in `base href` are
    actually used as base urls.

    * Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
    (TokenPreloadScanner::updatePredictedBaseURL):
    * LayoutTests/fast/parser/badurl-base-preloader-crash.html: Add Test Case
    * LayoutTests/fast/parser/badurl-base-preloader-crash-expected.txt: Add Test Case Expectation
    * LayoutTests/http/tests/loading/preload-ignore-invalid-base.html: Add Test Case
    * LayoutTests/http/tests/loading/resources/fail.js: Add Test Case Helper Script
    * LayoutTests/http/tests/loading/preload-ignore-invalid-base-expected.txt: Add Test Expectation

    Canonical link: https://commits.webkit.org/274963@main


  Commit: 23dd34655851f2ae0ae90c1455d7ae38916d649b
      https://github.com/WebKit/WebKit/commit/23dd34655851f2ae0ae90c1455d7ae38916d649b
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp

  Log Message:
  -----------
  Cherry-pick 274980 at main (4278c2f09831). https://bugs.webkit.org/show_bug.cgi?id=269707

    [LibWebRTC] Build fails with clang on Linux
    https://bugs.webkit.org/show_bug.cgi?id=269707

    Reviewed by Youenn Fablet.

    Remove duplicate fromStdString() implementations.

    * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
    (WebCore::LibWebRTCCertificateGenerator::fromStdString): Deleted.
    * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
    (WebCore::fromStdString): Deleted.

    Canonical link: https://commits.webkit.org/274980@main


Compare: https://github.com/WebKit/WebKit/compare/9c058fc33ab4...23dd34655851

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications