[webkit-changes] [WebKit/WebKit] 459c7f: [Skia] Ensure the correct fill sources are applied...

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 459c7fa7db217648a4885d72b971063b30698835
      https://github.com/WebKit/WebKit/commit/459c7fa7db217648a4885d72b971063b30698835
  Author: Pawel Lampe <plampe at igalia.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp
    M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
    M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h
    M Source/WebCore/platform/graphics/skia/PathSkia.cpp

  Log Message:
  -----------
  [Skia] Ensure the correct fill sources are applied for each fill paint used
https://bugs.webkit.org/show_bug.cgi?id=271047

Reviewed by Carlos Garcia Campos.

Currently, createFillPaint() invoked with clear color may actually pick up a shader instead.
This change separates automatic detection of fill source from createFillPaint() so that it's not used by mistake.
This change does the same for createStrokePaint().

* Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp:
(WebCore::FontCascade::drawGlyphs):
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::drawRect):
(WebCore::GraphicsContextSkia::drawNativeImageInternal):
(WebCore::GraphicsContextSkia::drawLine):
(WebCore::GraphicsContextSkia::drawEllipse):
(WebCore::GraphicsContextSkia::fillPath):
(WebCore::GraphicsContextSkia::createFillPaint const):
(WebCore::GraphicsContextSkia::setFillSource const):
(WebCore::GraphicsContextSkia::fillRect):
(WebCore::GraphicsContextSkia::drawDotsForDocumentMarker):
(WebCore::GraphicsContextSkia::clearRect):
(WebCore::GraphicsContextSkia::fillRoundedRectImpl):
(WebCore::GraphicsContextSkia::fillRectWithRoundedHole):
(WebCore::GraphicsContextSkia::drawPattern):
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h:

Canonical link: https://commits.webkit.org/276154@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications