[webkit-changes] [WebKit/WebKit] ff763d: [Legacy line layout removal] Remove horizontal inl...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff763d9dead40a6ce11cc71d1aed464dbc0045f9
      https://github.com/WebKit/WebKit/commit/ff763d9dead40a6ce11cc71d1aed464dbc0045f9
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/LegacyInlineFlowBox.h
    M Source/WebCore/rendering/LegacyInlineFlowBoxInlines.h
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/LegacyLineLayout.h
    M Source/WebCore/rendering/RenderBlockFlow.h

  Log Message:
  -----------
  [Legacy line layout removal] Remove horizontal inline box positioning
https://bugs.webkit.org/show_bug.cgi?id=271036
rdar://124660457

Reviewed by Alan Baradlay.

SVG is the last user of LegacyInlineBoxes but it does its own inline layout and does not use this code.

* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::LegacyInlineFlowBox::getFlowSpacingLogicalWidth): Deleted.
(WebCore::isLastChildForRenderer): Deleted.
(WebCore::isAncestorAndWithinBlock): Deleted.
(WebCore::LegacyInlineFlowBox::determineSpacingForFlowBoxes): Deleted.
(WebCore::LegacyInlineFlowBox::placeBoxesInInlineDirection): Deleted.
(WebCore::LegacyInlineFlowBox::placeBoxRangeInInlineDirection): Deleted.
* Source/WebCore/rendering/LegacyInlineFlowBox.h:
(WebCore::LegacyInlineFlowBox::LegacyInlineFlowBox):
(WebCore::LegacyInlineFlowBox::marginLogicalLeft const):
(WebCore::LegacyInlineFlowBox::marginLogicalRight const):
(WebCore::LegacyInlineFlowBox::includeLogicalLeftEdge const): Deleted.
(WebCore::LegacyInlineFlowBox::includeLogicalRightEdge const): Deleted.
(WebCore::LegacyInlineFlowBox::setEdges): Deleted.
(WebCore::LegacyInlineFlowBox::beginPlacingBoxRangesInInlineDirection): Deleted.
(WebCore::LegacyInlineFlowBox::endPlacingBoxRangesInInlineDirection): Deleted.
* Source/WebCore/rendering/LegacyInlineFlowBoxInlines.h:
(WebCore::LegacyInlineFlowBox::borderLogicalLeft const):
(WebCore::LegacyInlineFlowBox::borderLogicalRight const):
(WebCore::LegacyInlineFlowBox::paddingLogicalLeft const):
(WebCore::LegacyInlineFlowBox::paddingLogicalRight const):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::constructLine):
(WebCore::LegacyLineLayout::updateLogicalWidthForAlignment):
(WebCore::LegacyLineLayout::createLineBoxesFromBidiRuns):
(WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange):
(WebCore::endsWithHTMLSpaces): Deleted.
(WebCore::reachedEndOfTextRenderer): Deleted.
(WebCore::LegacyLineLayout::textAlignmentForLine const): Deleted.
(WebCore::setLogicalWidthForTextRun): Deleted.
(WebCore::LegacyLineLayout::computeExpansionForJustifiedText): Deleted.
(WebCore::updateLogicalInlinePositions): Deleted.
(WebCore::LegacyLineLayout::computeInlineDirectionPositionsForLine): Deleted.
(WebCore::expansionBehaviorForInlineTextBox): Deleted.
(WebCore::applyExpansionBehavior): Deleted.
(WebCore::inlineAncestorHasStartBorderPaddingOrMargin): Deleted.
(WebCore::inlineAncestorHasEndBorderPaddingOrMargin): Deleted.
(WebCore::isLastInFlowRun): Deleted.
(WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment): Deleted.
* Source/WebCore/rendering/LegacyLineLayout.h:
* Source/WebCore/rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::overrideTextAlignmentForLine const): Deleted.
(WebCore::RenderBlockFlow::adjustInlineDirectionLineBounds const): Deleted.

Canonical link: https://commits.webkit.org/276152@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications