[webkit-changes] [WebKit/WebKit] 56e388: Fix crash when `Device::generateAnOutOfMemoryError...

Charlie Wolfe noreply at github.com
Thu Mar 14 20:56:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56e388b8f65480d64712ebd2f65f837c95f7057d
      https://github.com/WebKit/WebKit/commit/56e388b8f65480d64712ebd2f65f837c95f7057d
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/repeated-out-of-memory-error-expected.txt
    A LayoutTests/fast/webgpu/repeated-out-of-memory-error.html
    M Source/WebGPU/WebGPU/Device.mm

  Log Message:
  -----------
  Fix crash when `Device::generateAnOutOfMemoryError` is repeatedly invoked
https://bugs.webkit.org/show_bug.cgi?id=270991
rdar://124475321

Reviewed by Mike Wyrzykowski.

`m_uncapturedErrorCallback` can only be called once, so it should always be cleared after calling it.

* LayoutTests/fast/webgpu/repeated-out-of-memory-error-expected.txt: Added.
* LayoutTests/fast/webgpu/repeated-out-of-memory-error.html: Added.
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::generateAnOutOfMemoryError):
(WebGPU::Device::generateAnInternalError):

Canonical link: https://commits.webkit.org/276135@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list