[webkit-changes] [WebKit/WebKit] 2524a1: REGRESSION(276077 at main) http/tests/navigation/pars...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2524a1511ef01e3daea353627dcf132cc92f66fa
      https://github.com/WebKit/WebKit/commit/2524a1511ef01e3daea353627dcf132cc92f66fa
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h

  Log Message:
  -----------
  REGRESSION(276077 at main) http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=271025
rdar://124649753

Reviewed by Charlie Wolfe.

If you run the test http/tests/navigation/page-cache-mediakeysession.html followed by the test
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html then RemoteLegacyCDMFactoryProxy::clear is called
from the RemoteLegacyCDMFactoryProxy destructor which is called from the unique_ptr destructor which is calld
from the GPUConnectionToWebProcess destructor.  ThreadSafeWeakPtr::get returns null if the destructor has begun,
but WeakPtr::get does not.  So to fix this crash, go back to using WeakPtr in this case.

* Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h:

Canonical link: https://commits.webkit.org/276132@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications