[webkit-changes] [WebKit/WebKit] 2a19d0: Fix flaky Web Extension exception tests on debug

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a19d0288716ba319aaa3d50ffca58ac30975286
      https://github.com/WebKit/WebKit/commit/2a19d0288716ba319aaa3d50ffca58ac30975286
  Author: Brian Weinstein <bweinstein at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICookies.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm

  Log Message:
  -----------
  Fix flaky Web Extension exception tests on debug
https://bugs.webkit.org/show_bug.cgi?id=270997
rdar://124632659

Reviewed by Timothy Hatcher.

It appears that these error tests were timing out on the bots. This PR fixes them in two ways:
1) Upping the timeout on debug builds to 6 seconds (since debug builds are slower to run these tests)
2) Splitting the tests that are timing out into separate tests

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::scheduleBackgroundContentToUnload):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICookies.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/276126@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications