[webkit-changes] [WebKit/WebKit] dd8b32: [MSE in Worker] ASSERT(canSafelyBeUsed());

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd8b32e43a1aca81e73e37b9b0378966616d27bc
      https://github.com/WebKit/WebKit/commit/dd8b32e43a1aca81e73e37b9b0378966616d27bc
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebCore/Modules/mediasource/MediaSource.cpp
    M Source/WebCore/Modules/mediasource/MediaSource.h

  Log Message:
  -----------
  [MSE in Worker] ASSERT(canSafelyBeUsed());
https://bugs.webkit.org/show_bug.cgi?id=270894
rdar://124500515

Reviewed by Youenn Fablet.

Only ever access the MediaSource::m_mediaElement member on the main thread.

Covered by existing tests.

* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::detachFromElement):
(WebCore::MediaSource::attachToElement):
(WebCore::MediaSource::stop):
* Source/WebCore/Modules/mediasource/MediaSource.h: We can't use check the value of m_mediaElement
to determine if one is attached or not. Add boolean instead.

Canonical link: https://commits.webkit.org/276100@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications