[webkit-changes] [WebKit/WebKit] bd8876: Use smart pointers and add null checks in WebInspe...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd887680e39bbeee7851815ee7dc90c1d8dbe4b0
      https://github.com/WebKit/WebKit/commit/bd887680e39bbeee7851815ee7dc90c1d8dbe4b0
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp

  Log Message:
  -----------
  Use smart pointers and add null checks in WebInspectorClient.cpp
https://bugs.webkit.org/show_bug.cgi?id=270929
rdar://123523102

Reviewed by Sihui Liu and David Kilzer.

Crash logs indicate `m_page` can be null in `WebInspectorClient::inspectedPageDestroyed()`.

* Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::~WebInspectorClient):
(WebKit::WebInspectorClient::inspectedPageDestroyed):
(WebKit::WebInspectorClient::frontendCountChanged):
(WebKit::WebInspectorClient::openLocalFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):
(WebKit::WebInspectorClient::didResizeMainFrame):
(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::hideHighlight):
(WebKit::WebInspectorClient::showPaintRect):
(WebKit::WebInspectorClient::showInspectorIndication):
(WebKit::WebInspectorClient::hideInspectorIndication):
(WebKit::WebInspectorClient::didSetSearchingForNode):
(WebKit::WebInspectorClient::elementSelectionChanged):
(WebKit::WebInspectorClient::timelineRecordingChanged):
(WebKit::WebInspectorClient::setDeveloperPreferenceOverride):
(WebKit::WebInspectorClient::setEmulatedConditions):
(WebKit::WebInspectorClient::drawRect):

Canonical link: https://commits.webkit.org/276093@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications