[webkit-changes] [WebKit/WebKit] 42ce83: Exiting of pip mode does not render well for for M...

youennf noreply at github.com
Thu Mar 14 06:08:27 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42ce839195219d25881a24f27d04c48500edd0ad
      https://github.com/WebKit/WebKit/commit/42ce839195219d25881a24f27d04c48500edd0ad
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm

  Log Message:
  -----------
  Exiting of pip mode does not render well for for MediaStream videos
https://bugs.webkit.org/show_bug.cgi?id=268750
rdar://122314896

Reviewed by Eric Carlson.

Our listener to bound changes is not useful when hacing the layer in GPUProcess and doing UI side rendering.
It kicks in when entering pip mode, which messes up the rendering computation.
Disable it in that case.

Manually tested.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::rootLayerBoundsDidChange):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVideoLayerSizeFenced):

Canonical link: https://commits.webkit.org/276086@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list