[webkit-changes] [WebKit/WebKit] 8e3980: CommandEncoder::clearTexture should only allocate ...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e39803a4c17f35737254dbc26993ab097ef187f
      https://github.com/WebKit/WebKit/commit/8e39803a4c17f35737254dbc26993ab097ef187f
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-03-13 (Wed, 13 Mar 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/copy-texture-more-than-4gb-expected.txt
    A LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html
    M Source/WebGPU/WebGPU/CommandEncoder.mm

  Log Message:
  -----------
  CommandEncoder::clearTexture should only allocate once to make temporaryBuffer
https://bugs.webkit.org/show_bug.cgi?id=270938
rdar://124475200

Reviewed by Mike Wyrzykowski.

Instead of allocating a Vector then allocating a buffer from it with newBufferWithBytes,
just use newBufferWithLength.  This also fixes crashes
where the buffer length is more than 4GB, which Vector can't allocate.

* LayoutTests/fast/webgpu/copy-texture-more-than-4gb-expected.txt: Added.
* LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html: Added.
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::clearTexture):

Canonical link: https://commits.webkit.org/276058@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications