[webkit-changes] [WebKit/WebKit] 40a84b: Do not promote MediaStream HTMLMediaElement to be ...

youennf noreply at github.com
Wed Mar 13 08:58:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40a84b10af90bfa6acfd1a8506517a304c699381
      https://github.com/WebKit/WebKit/commit/40a84b10af90bfa6acfd1a8506517a304c699381
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-03-13 (Wed, 13 Mar 2024)

  Changed paths:
    A LayoutTests/fast/mediastream/now-playing-and-mediastream-expected.txt
    A LayoutTests/fast/mediastream/now-playing-and-mediastream.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/html/MediaElementSession.cpp

  Log Message:
  -----------
  Do not promote MediaStream HTMLMediaElement to be NowPlaying without the web page using the MediaSession API
https://bugs.webkit.org/show_bug.cgi?id=270522
rdar://121562032

Reviewed by Eric Carlson.

When a web page is becoming NowPlaying, it has to react to Play/Pause commands from the user or from user actions like removing AirPods.
Pausing/Resuming media from regular video streaming is a good default, but pausing/resuming live video streaming (no buffering) is not a great default,
like can be seen in video conferencing or game streaming web sites.

We further restrict MediaStream HTMLMediaElement to becoming NowPlaying to the case where the website is using MediaSession API.
Either it should set metadata or provide action handlers.

* LayoutTests/fast/mediastream/now-playing-and-mediastream-expected.txt: Added.
* LayoutTests/fast/mediastream/now-playing-and-mediastream.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::hasNowPlayingInfo const):
(WebCore::MediaElementSession::playbackStateChanged):
(WebCore::MediaElementSession::actionHandlersChanged):

Canonical link: https://commits.webkit.org/276028@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list