[webkit-changes] [WebKit/WebKit] 0df991: Always use DDHighlightCreateWithRectsInVisibleRect...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0df9914623bbfc88ba44f2f270c2be15a8246f89
      https://github.com/WebKit/WebKit/commit/0df9914623bbfc88ba44f2f270c2be15a8246f89
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.h
    M Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.mm
    M Source/WebCore/page/mac/ImageOverlayControllerMac.mm
    M Source/WebCore/page/mac/ServicesOverlayController.mm

  Log Message:
  -----------
  Always use DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection in DDHighlight creation code
https://bugs.webkit.org/show_bug.cgi?id=270865
rdar://124465778

Reviewed by Tim Horton and Megan Gardner.

Currently, we call DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection
conditional on HAVE(DD_HIGHLIGHT_CREATE_WITH_SCALE). This is not
necessary because all calls to the DDHighlight creation method happen
in macOS-only codepaths, and the method in question is available on all
supported macOS configurations.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.h:
* Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.mm:
* Source/WebCore/page/mac/ImageOverlayControllerMac.mm:
(WebCore::ImageOverlayController::updateDataDetectorHighlights):
* Source/WebCore/page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
(WebCore::ServicesOverlayController::buildSelectionHighlight):

Canonical link: https://commits.webkit.org/276001@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications