[webkit-changes] [WebKit/WebKit] 92a81d: UnifiedPDF: Lookup pill has the wrong font size

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92a81dfc1401cf0f79b97c4123b7251bf4b08dd2
      https://github.com/WebKit/WebKit/commit/92a81dfc1401cf0f79b97c4123b7251bf4b08dd2
  Author: Tim Horton <thorton at apple.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.h
    M Source/WebKit/WebProcess/WebPage/FindController.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  UnifiedPDF: Lookup pill has the wrong font size
https://bugs.webkit.org/show_bug.cgi?id=270835
rdar://123667947

Reviewed by Abrar Rahman Protyasha and Simon Fraser.

Adopt TextIndicator for all UnifiedPDF text indication paths
(Lookup from force-press and from the context menu, in addition to
the existing find-in-page case).

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):
(WebKit::PDFPlugin::textForImmediateActionHitTestAtPoint):
(WebKit::PDFPlugin::lookupTextAtLocation): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::textIndicatorForCurrentSelection):
(WebKit::PDFPluginBase::textIndicatorForSelection): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::performImmediateActionHitTestAtLocation):
(WebKit::PDFPluginBase::dictionaryPopupInfoForSelection):
Move this PDFPlugin-specific code here from WebPageMac.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::performContextMenuAction):
(WebKit::UnifiedPDFPlugin::textIndicatorForCurrentSelection):
(WebKit::UnifiedPDFPlugin::textIndicatorForSelection):
(WebKit::UnifiedPDFPlugin::performDictionaryLookupAtLocation):
(WebKit::UnifiedPDFPlugin::dictionaryPopupInfoForSelection):
(WebKit::UnifiedPDFPlugin::showDefinitionForSelection):
(WebKit::UnifiedPDFPlugin::textForImmediateActionHitTestAtPoint):
Share more code between find and lookup.

(WebKit::UnifiedPDFPlugin::searchInDictionary): Deleted.
(WebKit::UnifiedPDFPlugin::showDefinitionForAttributedString): Deleted.
(WebKit::UnifiedPDFPlugin::lookupTextAtLocation): Deleted.
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::textIndicatorForCurrentSelection):
(WebKit::PluginView::performImmediateActionHitTestAtLocation const):
(WebKit::PluginView::textIndicatorForSelection): Deleted.
(WebKit::PluginView::lookupTextAtLocation const): Deleted.
* Source/WebKit/WebProcess/Plugins/PluginView.h:
Get rid of LookupTextResult.

* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): Deleted.

Canonical link: https://commits.webkit.org/275994@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications