[webkit-changes] [WebKit/WebKit] e880d7: chrome.action is undefined if the action key in th...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e880d73dbb4dc6c60f4b36486962a3ffba9e5c42
      https://github.com/WebKit/WebKit/commit/e880d73dbb4dc6c60f4b36486962a3ffba9e5c42
  Author: Elijah Sawyers <esawyers at apple.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm

  Log Message:
  -----------
  chrome.action is undefined if the action key in the manifest is missing or empty
https://bugs.webkit.org/show_bug.cgi?id=270814
rdar://122330191

Reviewed by Timothy Hatcher.

All keys in the dictionary in the manifest for action, browser_action, and
page_action should be optional. This patch makes the necessary changes for
that to be true.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::hasAction):
(WebKit::WebExtension::hasBrowserAction):
(WebKit::WebExtension::hasPageAction):
(WebKit::WebExtension::populateActionPropertiesIfNeeded):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm:
(WebKit::WebExtensionAPINamespace::isPropertyAllowed):

Canonical link: https://commits.webkit.org/275991@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications