[webkit-changes] [WebKit/WebKit] bc85b0: pictureInPicture in iOS does not work for camera s...

youennf noreply at github.com
Tue Mar 12 11:03:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc85b0e51049e8bf08fb1dc6a2dd538ffd982ebb
      https://github.com/WebKit/WebKit/commit/bc85b0e51049e8bf08fb1dc6a2dd538ffd982ebb
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm

  Log Message:
  -----------
  pictureInPicture in iOS does not work for camera streams
https://bugs.webkit.org/show_bug.cgi?id=268732
rdar://122295706

Reviewed by Eric Carlson.

In the past entering pip window mode for local camera would end up showing nothing as camera would get muted if the app goes in background.
With [AVCaptureSession initWithMediaEnvironment:], this restriction is no longer true.
We can thus enable pip window for local cameras.

Manually tested.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsPictureInPicture const): Deleted.

Canonical link: https://commits.webkit.org/275988@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list