[webkit-changes] [WebKit/WebKit] 5c2c34: Crash when quickly loading and unloading a Web Ext...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c2c34238fb70315d37c0d45c798e62ca746908c
      https://github.com/WebKit/WebKit/commit/5c2c34238fb70315d37c0d45c798e62ca746908c
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  -----------
  Crash when quickly loading and unloading a Web Extension.
https://webkit.org/b/270862
rdar://124126618

Reviewed by Jeff Miller.

When the extension controller is loading an extension context we move the local storage.
The lambda can escape and be called async, but was only capturing references. We need
to capture a protected this reference, and check if the context is still loaded
before proceeding after the move has finished.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::load):

Canonical link: https://commits.webkit.org/275986@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications