[webkit-changes] [WebKit/WebKit] d4124e: Versioning.
MyahCobbs
noreply at github.com
Tue Mar 12 10:25:28 PDT 2024
Branch: refs/heads/safari-7618.1.15.11-branch
Home: https://github.com/WebKit/WebKit
Commit: d4124ec0bf9e092be48ca5b5535a47d4066f5b95
https://github.com/WebKit/WebKit/commit/d4124ec0bf9e092be48ca5b5535a47d4066f5b95
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.1
Identifier: 272448.527 at safari-7618.1.15.11-branch
Commit: cd722420bfa8fc7f04b7e20fc31aedb9742bf1ac
https://github.com/WebKit/WebKit/commit/cd722420bfa8fc7f04b7e20fc31aedb9742bf1ac
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/JavaScriptCore/runtime/HasOwnPropertyCache.h
M Source/JavaScriptCore/runtime/LazyPropertyInlines.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VM.h
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/LazyRef.h
A Source/WTF/wtf/LazyUniqueRef.h
M Tools/TestWebKitAPI/CMakeLists.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WTF/LazyRef.cpp
A Tools/TestWebKitAPI/Tests/WTF/LazyUniqueRef.cpp
Log Message:
-----------
Cherry-pick 339bfd3e4a54. rdar://122509050
[WTF] Add LazyRef & LazyUniqueRef
https://bugs.webkit.org/show_bug.cgi?id=267830
rdar://121328458
Reviewed by Ryosuke Niwa.
This patch adds LazyRef and LazyUniqueRef. This is similar to LazyProperty in JSC.
We can set *stateless* lambda in the constructor side of the owner object so that it offers clean interface for lazy initialization,
which does not mess up the owner object's interface.
For example,
LazyUniqueRef<VM, Property> m_property;
Property& property() { return m_property.get(*this); }
First parameter is owner, which needs to be passed to `get`. And then, this `get` will automatically initialize if it is not initialized.
And the initialization code can be freely customized, but you do not need to define it as a VM's member! Instead, you can define it as a lambda inside VM.cpp.
// This lambda needs to be stateless. So it must not capture anything (otherwise, it hits crash because of RELEASE_ASSERT anyway).
m_property.initLater(
[](VM& vm, auto& ref) {
// You can do whatever. Even you can invoke the other property which can be further lazily initialized (so, it implicitly creates dependency graph of initialization).
ref.set(Property::create());
// And further, you can do anything after setting it. So these operations can see Property& via `vm.property()`.
});
Or you can set lambda in constructor, so like, VM's constructor list,
: m_property(
[](VM& vm, auto& ref) {
// You can do whatever. Even you can invoke the other property which can be further lazily initialized (so, it implicitly creates dependency graph of initialization).
ref.set(Property::create());
// And further, you can do anything after setting it. So these operations can see Property& via `vm.property()`.
})
, m_other()
, ...
This patch applies this to some of JSC::VM's fields, making definitions much cleaner by moving all messy parts into VM.cpp side and clean up VM.h's interface.
* Source/JavaScriptCore/runtime/HasOwnPropertyCache.h:
(JSC::HasOwnPropertyCache::Entry::offsetOfStructureID): Deleted.
(JSC::HasOwnPropertyCache::Entry::offsetOfImpl): Deleted.
(JSC::HasOwnPropertyCache::Entry::offsetOfResult): Deleted.
(JSC::HasOwnPropertyCache::operator delete): Deleted.
(JSC::HasOwnPropertyCache::create): Deleted.
(JSC::HasOwnPropertyCache::hash): Deleted.
(JSC::HasOwnPropertyCache::get): Deleted.
(JSC::HasOwnPropertyCache::tryAdd): Deleted.
(JSC::HasOwnPropertyCache::clear): Deleted.
(JSC::HasOwnPropertyCache::clearBuffer): Deleted.
(JSC::VM::ensureHasOwnPropertyCache): Deleted.
* Source/JavaScriptCore/runtime/LazyPropertyInlines.h:
(JSC::ElementType>::initLater):
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::invalidateStructureChainIntegrity):
(JSC::VM::ensureWatchdog): Deleted.
(JSC::VM::ensureHeapProfiler): Deleted.
(JSC::VM::ensureShadowChicken): Deleted.
(JSC::VM::ensureMegamorphicCacheSlow): Deleted.
* Source/JavaScriptCore/runtime/VM.h:
(JSC::VM::watchdog):
(JSC::VM::ensureWatchdog):
(JSC::VM::heapProfiler):
(JSC::VM::ensureHeapProfiler):
(JSC::VM::hasOwnPropertyCache):
(JSC::VM::ensureHasOwnPropertyCache):
(JSC::VM::megamorphicCache):
(JSC::VM::ensureMegamorphicCache):
(JSC::VM::shadowChicken):
(JSC::VM::ensureShadowChicken):
(JSC::VM::heapProfiler const): Deleted.
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/LazyRef.h: Added.
(WTF::LazyRef::~LazyRef):
(WTF::LazyRef::isInitialized const):
(WTF::LazyRef::get const):
(WTF::LazyRef::get):
(WTF::LazyRef::getIfExists const):
(WTF::LazyRef::getIfExists):
(WTF::LazyRef::initLater):
(WTF::LazyRef::set):
(WTF::LazyRef::callFunc):
* Source/WTF/wtf/LazyUniqueRef.h: Added.
(WTF::LazyUniqueRef::~LazyUniqueRef):
(WTF::LazyUniqueRef::isInitialized const):
(WTF::LazyUniqueRef::get const):
(WTF::LazyUniqueRef::get):
(WTF::LazyUniqueRef::getIfExists const):
(WTF::LazyUniqueRef::getIfExists):
(WTF::LazyUniqueRef::initLater):
(WTF::LazyUniqueRef::set):
(WTF::LazyUniqueRef::callFunc):
Canonical link: https://commits.webkit.org/273287@main
Identifier: 272448.528 at safari-7618.1.15.11-branch
Commit: 8fd810cdd79158c74e6c8dc8a469fa3c6f8e3580
https://github.com/WebKit/WebKit/commit/8fd810cdd79158c74e6c8dc8a469fa3c6f8e3580
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
A JSTests/stress/string-index-of-pathological.js
A JSTests/stress/v8-string-indexof-1.js
A JSTests/stress/v8-string-indexof-2.js
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/runtime/StringPrototype.cpp
M Source/JavaScriptCore/runtime/StringPrototypeInlines.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VM.h
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/text/ASCIIFastPath.h
A Source/WTF/wtf/text/AdaptiveStringSearcher.h
M Source/WTF/wtf/text/StringView.cpp
M Source/WTF/wtf/text/StringView.h
Log Message:
-----------
Cherry-pick 802150baed8d. rdar://121082299
[WTF] Adopt adaptive string searching
https://bugs.webkit.org/show_bug.cgi?id=268635
rdar://121082299
Reviewed by Mark Lam.
This patch adopts V8's StringSearch class. We tailor it to our use and name it AdaptiveStringSearcher.
We add `StringView::find(AdaptiveStringSearcherTables&, ...)` function which uses `AdaptiveStringSearcher`,
when the table is attached. In this way, we can use this function even without JSC VM for example.
The mechanism of this class is that, it requires additional space for large table (AdaptiveStringSearcherTables).
And it *adaptively* switches string searching algorithm: linearSearch -> boyerMooreHorspoolSearch -> boyerMooreSearch.
The reason is that the latter requires more costly preprocess to populate table data. For very simple case, linearSearch suffice,
but for more complex cases, the preprocess gets paid, and boyerMooreHorspoolSearch / boyerMooreSearch works better for performance.
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/runtime/StringPrototype.cpp:
(JSC::stringIndexOfImpl):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::stringIncludesImpl):
* Source/JavaScriptCore/runtime/StringPrototypeInlines.h:
(JSC::stringReplaceStringString):
(JSC::replaceUsingStringSearch):
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::VM):
* Source/JavaScriptCore/runtime/VM.h:
(JSC::VM::adaptiveStringSearcherTables):
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/text/ASCIIFastPath.h:
(WTF::charactersAreAllLatin1):
* Source/WTF/wtf/text/AdaptiveStringSearcher.h: Added.
(WTF::AdaptiveStringSearcherBase::exceedsOneByte):
(WTF::AdaptiveStringSearcherBase::alignDown):
(WTF::AdaptiveStringSearcherBase::getHighestValueByte):
(WTF::AdaptiveStringSearcherBase::findFirstCharacter):
(WTF::AdaptiveStringSearcherTables::badCharShiftTable):
(WTF::AdaptiveStringSearcherTables::goodSuffixShiftTable):
(WTF::AdaptiveStringSearcherTables::suffixTable):
(WTF::AdaptiveStringSearcher::AdaptiveStringSearcher):
(WTF::AdaptiveStringSearcher::search):
(WTF::AdaptiveStringSearcher::alphabetSize):
(WTF::AdaptiveStringSearcher::failSearch):
(WTF::AdaptiveStringSearcher::charOccurrence):
(WTF::AdaptiveStringSearcher::badCharTable):
(WTF::AdaptiveStringSearcher::goodSuffixShiftTable):
(WTF::AdaptiveStringSearcher::suffixTable):
(WTF::SubjectChar>::singleCharSearch):
(WTF::SubjectChar>::linearSearch):
(WTF::SubjectChar>::boyerMooreSearch):
(WTF::SubjectChar>::populateBoyerMooreTable):
(WTF::SubjectChar>::boyerMooreHorspoolSearch):
(WTF::SubjectChar>::populateBoyerMooreHorspoolTable):
(WTF::SubjectChar>::initialSearch):
(WTF::searchString):
(WTF::searchStringRaw):
* Source/WTF/wtf/text/StringView.cpp:
(WTF::StringView::find const):
* Source/WTF/wtf/text/StringView.h:
Canonical link: https://commits.webkit.org/274033@main
Identifier: 272448.529 at safari-7618.1.15.11-branch
Commit: bb353afe0000dd878e811291499b6eabb0f615a5
https://github.com/WebKit/WebKit/commit/bb353afe0000dd878e811291499b6eabb0f615a5
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M LayoutTests/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt
M LayoutTests/platform/ios/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
Log Message:
-----------
Cherry-pick 26aaa25dcbdc. rdar://122309325
REGRESSION(267824 at main): Changing HTMLCanvasElement width, height causes intermediate buffer allocations
https://bugs.webkit.org/show_bug.cgi?id=268745
rdar://122309325
Reviewed by Simon Fraser.
Resizing is intended to leave the buffer unallocated, so that
sequential width, height assignments will not allocate multiple times.
This intention was nullified by CanvasRenderingContext2DBase::reset().
Calling resetTransform redundantly would recreate the buffer
immediately from width, height attribute setters.
The transform reset is redundant, the context transform is reset when
the context state saver is restored and re-saved.
Clearing the canvas doesn't need to use public
CanvasRenderingContext2DBase::clearCanvas() that will mutate the context
state. The state is in known state with initial transform, and thus it
doesn't need transform mutation.
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::reset):
Canonical link: https://commits.webkit.org/274135@main
Identifier: 272448.530 at safari-7618.1.15.11-branch
Commit: 124302e19b7c14b3346ad27adde026b96afac65d
https://github.com/WebKit/WebKit/commit/124302e19b7c14b3346ad27adde026b96afac65d
Author: Jer Noble <jer.noble at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
A LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal-expected.txt
A LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal.html
M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
Log Message:
-----------
Cherry-pick 8c14e2cb8214. rdar://121931039
[Cocoa] Netflix.com key renewal fails, causes playback errors, stuttering.
https://bugs.webkit.org/show_bug.cgi?id=268830
rdar://121931039
Reviewed by Andy Estes.
When adding a workaround for a platform change in behavior in the modern AVContentKeySession path,
a behavior was introduced which narrowly affects the way Netflix.com preloads keys. Previously,
a "renew" message would result in the resulting AVContentKeyRequest replacing the entire set of
pre-loaded keys from the previous request, some of which were in use by Netflix.
Rather than replace the entire set, replace only the AVContentKeyRequest within the batch of requests
whose contentKeySpecifier has a maching identifier to the replacement.
* LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal-expected.txt: Added.
* LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal.html: Added.
* Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
Canonical link: https://commits.webkit.org/274172@main
Identifier: 272448.531 at safari-7618.1.15.11-branch
Commit: 1678e84d21521ee39a3b8ef93e1c99d5e5f28350
https://github.com/WebKit/WebKit/commit/1678e84d21521ee39a3b8ef93e1c99d5e5f28350
Author: Per Arne Vollan <pvollan at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Log Message:
-----------
Cherry-pick 6e9bfa7a9bb1. rdar://122118903
[Catalyst] AX server not started in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=268887
rdar://122118903
Reviewed by Chris Dumez.
The code to eagerly start the AX server in the WebContent process was only enabled for iOS. We should also enable it on Catalyst.
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::webProcessAccessibilityBundlePath):
(WebKit::registerWithAccessibility):
Canonical link: https://commits.webkit.org/274214@main
Identifier: 272448.532 at safari-7618.1.15.11-branch
Commit: f8a07d3e50e5d41075b648e0d0087f7cd53aa0f9
https://github.com/WebKit/WebKit/commit/f8a07d3e50e5d41075b648e0d0087f7cd53aa0f9
Author: Ben Nham <nham at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
Log Message:
-----------
Cherry-pick f4ce57789de5. rdar://121185956
hideContentUntilPendingUpdate async IPC call during backgrounding blocks process suspension
https://bugs.webkit.org/show_bug.cgi?id=268799
rdar://121185956
Reviewed by Chris Dumez.
On iOS, when the UIProcess goes into the background, it eventually calls in to
hideContentUntilPendingUpdate through this call stack:
```
WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate()
WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground()
WebKit::ApplicationStateTracker::didCompleteSnapshotSequence()
```
The problem is that we recently added an async `DrawingArea::DispatchAfterEnsuringDrawing` IPC with
reply handler call to hideContentUntilPendingUpdate (see 269776 at main, 270672 at main, 271260 at main). An
async IPC with a reply handler in the UIProcess implicitly takes out a background activity which
prevents the WebContent process (and also the UIProcess) from suspending until the reply handler
runs. Unfortunately, since the WebContent process is in the background, presumably it doesn't
render, so the DispatchAfterEnsuringDrawing reply handler doesn't run, and the background activity
also never completes. We basically end up blocking process suspension entirely until the 15 second
timer in ProcessStateMonitor expires and forcefully invalidates all background activities for all
processes.
We need to fix this by reworking the logic somehow or by making this DispatchAfterEnsuringDrawing
IPC not create a background activity. Here I'm just trying to make the IPC call not start a
background activity.
Note that there's also a DispatchAfterEnsuringDrawing call in WebPageProxy that I didn't touch since
I don't have evidence that it's causing a background power regression, but I wonder if that also
should avoid creating a background activity.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate):
Canonical link: https://commits.webkit.org/274157@main
Identifier: 272448.533 at safari-7618.1.15.11-branch
Commit: a92711a7c163e49eaed660349e46d4a50cf210ae
https://github.com/WebKit/WebKit/commit/a92711a7c163e49eaed660349e46d4a50cf210ae
Author: Russell Epstein <repstein at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
Log Message:
-----------
Revert "Cherry-pick f4ce57789de5. rdar://121185956"
This reverts commit f8a07d3e50e5d41075b648e0d0087f7cd53aa0f9.
Identifier: 272448.534 at safari-7618.1.15.11-branch
Commit: c2ecaaa9551d1007b7e6739fba7937b6c581f04b
https://github.com/WebKit/WebKit/commit/c2ecaaa9551d1007b7e6739fba7937b6c581f04b
Author: Simon Fraser <simon.fraser at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-dialog-expected.txt
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-dialog.html
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen-expected.txt
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen-variant-expected.txt
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen-variant.html
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen.html
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-popover-expected.txt
A LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-popover.html
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerCompositor.h
Log Message:
-----------
Cherry-pick 1021d66fe7c3. rdar://121960496
Crash under RenderLayer::calculateClipRects() when going into fullscreen
https://bugs.webkit.org/show_bug.cgi?id=268891
rdar://121960496
Reviewed by Alan Baradlay.
A combination of top layer and compositing backing sharing can cause a null de-ref when entering fullscreen,
or using modal dialogs or popovers.
The issue occurs when the renderer going into top layer participates in a backing sharing sequence, in the
`RenderLayer::paintsIntoProvidedBacking()` sense. What happens in that case is that after the top layer
configuration is changed we do a layout, after which `RenderLayerBacking::updateAfterLayout()` calls
`RenderLayerBacking::updateCompositedBounds()` (this seems like an odd thing to do, because we're going
to do a compositing update anyway, but a comment explains why we do it). This call requires that we compute
clip rects, which calls `RenderLayer::canUseOffsetFromAncestor()`, which gets confused because the ancestor
layer is no longer an ancestor.
The fix is to clear any relevant backing sharing sequences when going into top layer, where "relevant" means
backing sharing sequences in the stacking context of the layer that's going into top layer. We do that
by calling into RenderLayerCompositor from `RenderLayer::establishesTopLayerWillChange()`. Normally traversing
layers in a stacking context would walk the z-order lists, and this works for popover and dialog, but fullscreen
triggers a style update before this code runs, which clears the z-order lists. So this stacking context
traversal is written in terms of the RenderLayer tree (like `collectLayers()`).
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-dialog-expected.txt: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-dialog.html: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen-expected.txt: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen-variant-expected.txt: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen-variant.html: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-fullscreen.html: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-popover-expected.txt: Added.
* LayoutTests/compositing/shared-backing/top-layer/backing-sharing-split-by-popover.html: Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::establishesTopLayerWillChange):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::establishesTopLayerWillChangeForLayer):
(WebCore::clearBackingSharingWithinStackingContext):
(WebCore::RenderLayerCompositor::clearBackingProviderSequencesInStackingContextOfLayer):
* Source/WebCore/rendering/RenderLayerCompositor.h:
Canonical link: https://commits.webkit.org/274290@main
Identifier: 272448.536 at safari-7618.1.15.11-branch
Commit: 8bc242185f1cf0571a2e3f6b04bb32b7dc86978e
https://github.com/WebKit/WebKit/commit/8bc242185f1cf0571a2e3f6b04bb32b7dc86978e
Author: Elliott Williams <emw at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WTF/wtf/spi/cocoa/IOSurfaceSPI.h
M Source/WTF/wtf/spi/darwin/XPCSPI.h
M Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
A Source/WebCore/PAL/pal/spi/ios/BrowserEngineKitSPI.h
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
Log Message:
-----------
Cherry-pick 5cdf58dba105. rdar://121706323
Cherry-pick 274016 at main (98226f6cc5f3). rdar://problem/121706323
[iOS] Update SPI headers for iOS 17.4
https://bugs.webkit.org/show_bug.cgi?id=268210
rdar://problem/121706323
Reviewed by Jonathan Bedard and Alexey Proskuryakov.
Add platform flags for libxpc (which is API as of iOS 17.4+) and for
other SPI that were promoted to API as part of the BrowserEngineKit
introduction. Use them to avoid redeclaring things that are now
publicly available.
Additionally, write new BrowserEngineKit SPI declarations for symbols
that are used in testing and by SPI clients of WebKit.
* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/spi/cocoa/IOSurfaceSPI.h:
* Source/WTF/wtf/spi/darwin/XPCSPI.h:
* Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h:
* Source/WebCore/PAL/pal/spi/ios/BrowserEngineKitSPI.h:
* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Tools/TestRunnerShared/spi/UIKitSPIForTesting.h:
Canonical link: https://commits.webkit.org/274016@main
Canonical link: https://commits.webkit.org/272448.522@safari-7618-branch
Identifier: 272448.537 at safari-7618.1.15.11-branch
Commit: 017b58551e886ab4d9eaa2e610b9f9fc017e52f0
https://github.com/WebKit/WebKit/commit/017b58551e886ab4d9eaa2e610b9f9fc017e52f0
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WTF/wtf/spi/cocoa/IOSurfaceSPI.h
M Source/WTF/wtf/spi/darwin/XPCSPI.h
M Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
R Source/WebCore/PAL/pal/spi/ios/BrowserEngineKitSPI.h
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
Log Message:
-----------
Revert "Cherry-pick 5cdf58dba105. rdar://121706323"
This reverts commit 8bc242185f1cf0571a2e3f6b04bb32b7dc86978e.
Identifier: 272448.538 at safari-7618.1.15.11-branch
Commit: 3415060c78ad2739a197d73882ccb307c5cbeefe
https://github.com/WebKit/WebKit/commit/3415060c78ad2739a197d73882ccb307c5cbeefe
Author: Russell Epstein <repstein at apple.com>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.2
Canonical link: https://commits.webkit.org/272448.538@safari-7618.1.15.11-branch
Commit: 1b021b821294e95f03c81c613091fe6829a82c60
https://github.com/WebKit/WebKit/commit/1b021b821294e95f03c81c613091fe6829a82c60
Author: Jer Noble <jer.noble at apple.com>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Log Message:
-----------
Cherry-pick 56b164c3ab85. rdar://122444388
REGRESSION(272969 at main): Null-deref crash in SourceBufferPrivateAVFObjC::trackDidChangeEnabled
https://bugs.webkit.org/show_bug.cgi?id=268921
rdar://122444388
Reviewed by Eric Carlson.
The WebAVSampleBufferListener m_listener is invalidated and destroyed in SourceBufferPrivateAVFObjC::destroyRenderers(),
and is never recreated. It is subsequently used without nil-checking the next time a renderer is recreated. Rather than
destroying and re-creating whenever renderers are destroyed and created, make it a Ref<> object whose lifetime is the same
(or longer) as the object which owns it.
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
Canonical link: https://commits.webkit.org/274323@main
Identifier: 272448.540 at safari-7618.1.15.11-branch
Commit: a01fb44e9853b4ea5686e9a54712fc57f726c5f1
https://github.com/WebKit/WebKit/commit/a01fb44e9853b4ea5686e9a54712fc57f726c5f1
Author: Alan Baradlay <zalan at apple.com>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
A LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width-expected.html
A LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Log Message:
-----------
Cherry-pick 06f1371ababe. rdar://122586549
[IFC][Ruby] Text are clipped at the bottom on some pages with ruby in Books
https://bugs.webkit.org/show_bug.cgi?id=269079
<rdar://122586549>
Reviewed by Antti Koivisto.
Take ruby width adjustment (annotation box is wider than base content) into account when non-trivial line breaking requires us to rebuild the current line.
* LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width-expected.html: Added.
* LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::rebuildLineWithInlineContent): This is the exact copy of what we do in candidateContentForLine when collecting the content for current line.
Canonical link: https://commits.webkit.org/274387@main
Identifier: 272448.541 at safari-7618.1.15.11-branch
Commit: 3cb1353c3580cc97feb556fdc62717f9df5480ad
https://github.com/WebKit/WebKit/commit/3cb1353c3580cc97feb556fdc62717f9df5480ad
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
Log Message:
-----------
Apply patch. rdar://122361008
Identifier: 272448.542 at safari-7618.1.15.11-branch
Commit: 27352c31a9ea745f675f60c06e722637c3c1108e
https://github.com/WebKit/WebKit/commit/27352c31a9ea745f675f60c06e722637c3c1108e
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Log Message:
-----------
Revert "Cherry-pick 56b164c3ab85. rdar://122444388"
This reverts commit 1b021b821294e95f03c81c613091fe6829a82c60.
Identifier: 272448.543 at safari-7618.1.15.11-branch
Commit: d302ed9e69a04e24088841c108aa3564bab582e4
https://github.com/WebKit/WebKit/commit/d302ed9e69a04e24088841c108aa3564bab582e4
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.11.3
Identifier: 272448.543 at safari-7618.1.15.11-branch
Commit: eb6fa89b201f2451b904ce65dabf56f8e4997ad8
https://github.com/WebKit/WebKit/commit/eb6fa89b201f2451b904ce65dabf56f8e4997ad8
Author: Alan Baradlay <zalan at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
A LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap-expected.html
A LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap.html
M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
Log Message:
-----------
Cherry-pick 9f3eab39f42a. rdar://122501121
[IFC][Ruby] Some characters are overlapped (Hiragana + Kanji character with Ruby)
https://bugs.webkit.org/show_bug.cgi?id=269064
<rdar://122501121>
Reviewed by Antti Koivisto.
1. When annotation is wide than the base content, we slightly pull adjacent content under the annotation on both sides
2. Pulling the "after" content (boxes to the right of the ruby) means shifting all the runs as one monolithic content.
However in case of justified alignment, as we are supposed to keep the spacing intact, we only adjust the adjacent run
by moving and expanding it (expanding ensure the rest of the "after" content stays stationary).
* LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap-expected.html: Added.
* LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap.html: Added.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
Canonical link: https://commits.webkit.org/274373@main
Identifier: 272448.544 at safari-7618.1.15.11-branch
Commit: 2d8822487c8a72cba8b08f54eda18d09840f6c95
https://github.com/WebKit/WebKit/commit/2d8822487c8a72cba8b08f54eda18d09840f6c95
Author: Alan Baradlay <zalan at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
A LayoutTests/fast/ruby/annotation-clipped-first-line-expected.html
A LayoutTests/fast/ruby/annotation-clipped-first-line.html
M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
Log Message:
-----------
Cherry-pick da3c5b4ca5ce. rdar://122586539
[IFC][Ruby] Ruby character is clipped at right edge of the page
https://bugs.webkit.org/show_bug.cgi?id=269065
<rdar://122586539>
Reviewed by Antti Koivisto.
See comment in RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase.
* LayoutTests/fast/ruby/annotation-clipped-first-line-expected.html: Added.
* LayoutTests/fast/ruby/annotation-clipped-first-line.html: Added.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase):
Canonical link: https://commits.webkit.org/274376@main
Identifier: 272448.545 at safari-7618.1.15.11-branch
Commit: 52a77985339370ef096c183a4cbb1adfc07a6dc7
https://github.com/WebKit/WebKit/commit/52a77985339370ef096c183a4cbb1adfc07a6dc7
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebCore/dom/QualifiedName.h
Log Message:
-----------
Cherry-pick 2511322b2a30. rdar://122693092
Use QualifiedNameImpl* as the hash key for Attribute
https://bugs.webkit.org/show_bug.cgi?id=269093
Reviewed by Chris Dumez and Yusuke Suzuki.
Use QualifiedNameImpl* instead of QualifiedName::hash as the hasher input
for Attribute to avoid the indirect memory loads.
* Source/WebCore/dom/QualifiedName.h:
(WebCore::add):
Canonical link: https://commits.webkit.org/274411@main
Identifier: 272448.546 at safari-7618.1.15.11-branch
Commit: 3a87edc38d9f8ebe4751727a62a7f346e4fef30b
https://github.com/WebKit/WebKit/commit/3a87edc38d9f8ebe4751727a62a7f346e4fef30b
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
A LayoutTests/fast/dom/dom-parser-head-body-order-expected.txt
A LayoutTests/fast/dom/dom-parser-head-body-order.html
M Source/WebCore/dom/Document.cpp
M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp
Log Message:
-----------
Apply patch. rdar://122720540
Connect body to the document before invoking tryFastParsingHTMLFragment
https://bugs.webkit.org/show_bug.cgi?id=269047
Reviewed by Anne van Kesteren and Yusuke Suzuki.
Connect the body element to the document before invoking tryFastParsingHTMLFragment
in Document::setMarkupUnsafe to avoid the secondary insertedIntoAncestor call.
We need to disable coalescing of childrenChanged in this case because we need to call
didFinishInsertingNode on some of the newly connected nodes.
Also added a regression test for a bug that was not caught during the development.
* LayoutTests/fast/dom/dom-parser-head-body-order-expected.txt: Added.
* LayoutTests/fast/dom/dom-parser-head-body-order.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::setMarkupUnsafe):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::parseChildren):
(WebCore::HTMLFastPathParser::parseContainerElement):
(WebCore::HTMLFastPathParser::parseVoidElement):
Canonical link: https://commits.webkit.org/274429@main
Identifier: 272448.547 at safari-7618.1.15.11-branch
Commit: 73b4e474c30d86faf0f04c94393abb26904ba74e
https://github.com/WebKit/WebKit/commit/73b4e474c30d86faf0f04c94393abb26904ba74e
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WTF/wtf/text/StringCommon.h
Log Message:
-----------
Cherry-pick bacdbdaaf182. rdar://122829453
[JSC] Micro-optimize String equal operation with UChar / LChar
https://bugs.webkit.org/show_bug.cgi?id=268684
rdar://122224476
Reviewed by Ryosuke Niwa.
This patch micro-optimizes String equal operation with different characters (UChar* and LChar*).
ToT Patched
todomvc-javascript-es5-json-parse 37.6466+-0.1862 ^ 37.1991+-0.1560 ^ definitely 1.0120x faster
todomvc-javascript-es6-webpack-json-parse
58.9239+-0.3310 ^ 58.2251+-0.1931 ^ definitely 1.0120x faster
* Source/WTF/wtf/text/StringCommon.h:
Canonical link: https://commits.webkit.org/274064@main
Identifier: 272448.548 at safari-7618.1.15.11-branch
Commit: 73b6b77a165825bd676861aff941db9efdf8c40c
https://github.com/WebKit/WebKit/commit/73b6b77a165825bd676861aff941db9efdf8c40c
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/JavaScriptCore/runtime/JSONAtomStringCache.h
M Source/JavaScriptCore/runtime/JSONAtomStringCacheInlines.h
M Source/WTF/wtf/text/StringCommon.h
Log Message:
-----------
Cherry-pick 35a17ac7fc54. rdar://122590409
[JSC] Accelerate JSONAtomStringCache
https://bugs.webkit.org/show_bug.cgi?id=269027
rdar://122590409
Reviewed by Mark Lam.
This patch makes JSON parsing faster by embedding small string content itself into the cache.
AtomString is stored in the per-thread hash table. And to get that, we need to do hash-table lookup, which is costly.
These cache can avoid doing that. But still, to check the cache validity, we are still accessing to the string content
of the AtomString. While the input string content is almost always already in CPU cache since we created this input string,
AtomString content is very unlikely in the CPU cache. So if we can put this content in much more CPU friendly place, we can
avoid cache miss much.
In this patch, we leverage the fact that this cache only stores very small strings. So instead of using content inside AtomString,
we also copy the string content into the cache's slot itself. So string comparison does not encounter cache miss and accelerate
the lookup performance. Good part of AtomString is that, after getting this pointer, we rarely access to the string content of AtomString,
so now, we can avoid access to this string content in majority of cases.
* Source/JavaScriptCore/runtime/JSONAtomStringCache.h:
(JSC::JSONAtomStringCache::makeIdentifier):
(JSC::JSONAtomStringCache::clear):
(JSC::JSONAtomStringCache::cacheSlot):
(JSC::JSONAtomStringCache::cache): Deleted.
* Source/JavaScriptCore/runtime/JSONAtomStringCacheInlines.h:
(JSC::JSONAtomStringCache::make):
* Source/WTF/wtf/text/StringCommon.h:
Canonical link: https://commits.webkit.org/274348@main
Identifier: 272448.549 at safari-7618.1.15.11-branch
Commit: e5e6058e4ca5de2b9972aa69b613f3bd4e7fa2a6
https://github.com/WebKit/WebKit/commit/e5e6058e4ca5de2b9972aa69b613f3bd4e7fa2a6
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/JavaScriptCore/jit/JITWorklist.cpp
M Source/JavaScriptCore/jit/JITWorklist.h
M Source/JavaScriptCore/jit/JITWorklistThread.cpp
M Source/JavaScriptCore/jit/JITWorklistThread.h
Log Message:
-----------
Cherry-pick 17e76f594e5e. rdar://122677279
[JSC] Skip notifyOne when all JIT threads are running
https://bugs.webkit.org/show_bug.cgi?id=269111
rdar://122677279
Reviewed by Mark Lam.
Let's avoid calling notifyOne when all JIT threads are currently running.
In that case, they will pick the enqueued plan without notifying anyway.
This can skip some of costly syscalls like pthread_condvar related ones.
We also change JITWorklist::suspendAllThreads to first use tryLock for all threads.
So then, we can eagerly suspend currently-not-running-threads. And after that,
we eventually ensure all threads are not running. This avoids starting JIT compilation
in the latter thread while it was not having that when JITWorklist::suspendAllThreads started.
* Source/JavaScriptCore/jit/JITWorklist.cpp:
(JSC::JITWorklist::JITWorklist):
(JSC::JITWorklist::enqueue):
(JSC::JITWorklist::removeDeadPlans):
(JSC::JITWorklist::visitWeakReferences):
* Source/JavaScriptCore/jit/JITWorklist.h:
* Source/JavaScriptCore/jit/JITWorklistThread.cpp:
(JSC::JITWorklistThread::work):
* Source/JavaScriptCore/jit/JITWorklistThread.h:
Canonical link: https://commits.webkit.org/274407@main
Identifier: 272448.550 at safari-7618.1.15.11-branch
Commit: 56a875dd255c7465c222a3e7e4d6d1c74093d6e3
https://github.com/WebKit/WebKit/commit/56a875dd255c7465c222a3e7e4d6d1c74093d6e3
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
M Source/JavaScriptCore/jit/JITOpcodes.cpp
Log Message:
-----------
Cherry-pick a36c2519d4ee. rdar://122674588
[JSC] Spew strict-eq Baseline JIT code with constant strings
https://bugs.webkit.org/show_bug.cgi?id=269106
rdar://122674588
Reviewed by Alexey Shvayka.
Let's leverage the fact that there are many `"string" === x` comparisons.
In that case, we can emit very specific optimized code even in Baseline JIT easily.
This patch adds `StringIdent === x` case optimizations in Baseline JIT.
Furthermore, we found that
```
switch (expr) {
case "string1":
...
case "string2":
...
case variable:
...
}
```
case is emitting very inefficient bytecode, which does not use constant register directly with `jstricteq`.
As a result, my new optimization does not kick in with this. This patch also fixes BytecodeGenerator to make
this new optimization work well by emitting `jstricteq constant, x`.
* Source/JavaScriptCore/jit/JITOpcodes.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::compileOpStrictEqJump):
Canonical link: https://commits.webkit.org/274418@main
Identifier: 272448.551 at safari-7618.1.15.11-branch
Commit: 5013c18b25e57a5b253dc02a18eceef9dbfcc557
https://github.com/WebKit/WebKit/commit/5013c18b25e57a5b253dc02a18eceef9dbfcc557
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/JavaScriptCore/bytecode/PutByStatus.cpp
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
Log Message:
-----------
Cherry-pick d077f1d5c030. rdar://122689419
[JSC] Enable Megamorphic Cache for enumerator_put_by_val / enumerator_get_by_val in upper tiers
https://bugs.webkit.org/show_bug.cgi?id=269129
rdar://122689419
Reviewed by Mark Lam.
This patch enables embedded DFG / FTL megamorphic cache for enumerator_put_by_val / enumerator_get_by_val.
We obtain PutByStatus / GetByStatus, and if it says "this was megamorphic in lower tiers", then we use PutByValMegamorphic / GetByValMegamorphic.
* Source/JavaScriptCore/bytecode/PutByStatus.cpp:
(JSC::PutByStatus::computeFromLLInt):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Canonical link: https://commits.webkit.org/274421@main
Identifier: 272448.552 at safari-7618.1.15.11-branch
Commit: 36d624c2dd4a7b9a2101b7d30e93a140cc41ecc3
https://github.com/WebKit/WebKit/commit/36d624c2dd4a7b9a2101b7d30e93a140cc41ecc3
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebCore/dom/ContainerNodeAlgorithms.cpp
M Source/WebCore/html/HTMLFormControlElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLObjectElement.cpp
M Source/WebCore/html/ValidatedFormListedElement.cpp
M Source/WebCore/svg/SVGFEImageElement.cpp
M Source/WebCore/svg/SVGTextPathElement.cpp
Log Message:
-----------
Cherry-pick 980a1d5fec28. rdar://121612950
Restrict didFinishInsertingNode to connected nodes
https://bugs.webkit.org/show_bug.cgi?id=268051
Reviewed by Wenson Hsieh.
Don't call didFinishInsertingNode when a node is not connected to a document.
* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::notifyNodeInsertedIntoTree):
(WebCore::notifyChildNodeInserted):
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp:
(WebCore::HTMLMaybeFormAssociatedCustomElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedIntoAncestor):
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::insertedIntoAncestor): Call resetFormOwner when this insertion
didn't result in getting connected to a new document since didFinishInsertingNode won't be called in
such cases. It's okay to call this function synchronously in this case since we don't rely on
TreeScope::getElementById when the node is not connected to a a document in findAssociatedForm.
* Source/WebCore/svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedIntoAncestor):
* Source/WebCore/svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoAncestor):
Canonical link: https://commits.webkit.org/273523@main
Identifier: 272448.553 at safari-7618.1.15.11-branch
Commit: b7671898d2389b5b0fb2759712b88918eaf5040e
https://github.com/WebKit/WebKit/commit/b7671898d2389b5b0fb2759712b88918eaf5040e
Author: Joshua Hoffman <jhoffman23 at apple.com>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
Log Message:
-----------
Cherry-pick 58895edc47c1. rdar://122778867
AX: Missing _prepareAccessibilityCall in accessibilityIsInNonNativeTextControl
https://bugs.webkit.org/show_bug.cgi?id=269214
rdar://122778867
Reviewed by Andres Gonzalez.
We need to add a _prepareAccessibilityCall to avoid a nullptr dereference.
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsInNonNativeTextControl]):
Canonical link: https://commits.webkit.org/274497@main
Identifier: 272448.554 at safari-7618.1.15.11-branch
Commit: ad50ccd99da0ba186ab45c729a02e3700b13db9a
https://github.com/WebKit/WebKit/commit/ad50ccd99da0ba186ab45c729a02e3700b13db9a
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-13 (Tue, 13 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.4
Identifier: 272448.556 at safari-7618.1.15.11-branch
Commit: 01bca4562e26639e22d9987f88b1ee865d718f96
https://github.com/WebKit/WebKit/commit/01bca4562e26639e22d9987f88b1ee865d718f96
Author: Alan Baradlay <zalan at apple.com>
Date: 2024-02-13 (Tue, 13 Feb 2024)
Changed paths:
A LayoutTests/fast/ruby/ruby-base-content-should-not-wrap-expected.html
A LayoutTests/fast/ruby/ruby-base-content-should-not-wrap.html
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
Log Message:
-----------
Cherry-pick 2c41110b8852. rdar://122811940
[IFC][Ruby] Ruby base content may wrap even when style says no
https://bugs.webkit.org/show_bug.cgi?id=269235
<rdar://122811940>
Reviewed by Antti Koivisto.
There's no soft wrap opportunity between 2 adjacent non-whitespace characters when style says nowrap.
* LayoutTests/fast/ruby/ruby-base-content-should-not-wrap-expected.html: Added.
* LayoutTests/fast/ruby/ruby-base-content-should-not-wrap.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::isAtSoftWrapOpportunity):
Canonical link: https://commits.webkit.org/272448.537@safari-7618-branch
Identifier: 272448.557 at safari-7618.1.15.11-branch
Commit: d0e878794246c7c5562b8396a4f48e1ef789ba3b
https://github.com/WebKit/WebKit/commit/d0e878794246c7c5562b8396a4f48e1ef789ba3b
Author: Jer Noble <jer.noble at apple.com>
Date: 2024-02-13 (Tue, 13 Feb 2024)
Changed paths:
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Log Message:
-----------
Cherry-pick 56b164c3ab85. rdar://122444388
REGRESSION(272969 at main): Null-deref crash in SourceBufferPrivateAVFObjC::trackDidChangeEnabled
https://bugs.webkit.org/show_bug.cgi?id=268921
rdar://122444388
Reviewed by Eric Carlson.
The WebAVSampleBufferListener m_listener is invalidated and destroyed in SourceBufferPrivateAVFObjC::destroyRenderers(),
and is never recreated. It is subsequently used without nil-checking the next time a renderer is recreated. Rather than
destroying and re-creating whenever renderers are destroyed and created, make it a Ref<> object whose lifetime is the same
(or longer) as the object which owns it.
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
Canonical link: https://commits.webkit.org/274323@main
Identifier: 272448.558 at safari-7618.1.15.11-branch
Commit: dbebfcd39fff376dc783a19f1b8a6b65e0e33470
https://github.com/WebKit/WebKit/commit/dbebfcd39fff376dc783a19f1b8a6b65e0e33470
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/rendering/RenderMenuList.cpp
Log Message:
-----------
Versioning.
WebKit-618.1.15.11.5
Canonical link: https://commits.webkit.org/272448.558@safari-7618.1.15.11-branch
Commit: b8dfb3a74f1f6b8e9ec9964bbf2f6c85642911f5
https://github.com/WebKit/WebKit/commit/b8dfb3a74f1f6b8e9ec9964bbf2f6c85642911f5
Author: Dan Robson <dan_robson at apple.com>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/rendering/RenderMenuList.cpp
Log Message:
-----------
Revert "Versioning."
This reverts commit dbebfcd39fff376dc783a19f1b8a6b65e0e33470.
Commit: 85867c4f756e2bbeafd75869611f2d33ef7fa9fc
https://github.com/WebKit/WebKit/commit/85867c4f756e2bbeafd75869611f2d33ef7fa9fc
Author: Dan Robson <dan_robson at apple.com>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.11.5
Canonical link: https://commits.webkit.org/272448.560@safari-7618.1.15.11-branch
Commit: a5fff16c7994796ce6def8c0c1cf20ed5f5c4012
https://github.com/WebKit/WebKit/commit/a5fff16c7994796ce6def8c0c1cf20ed5f5c4012
Author: Chris Dumez <cdumez at apple.com>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/rendering/RenderMenuList.cpp
Log Message:
-----------
Cherry-pick 35318b4d5407. rdar://119790256
Crash under ~RenderMenuList due to CheckedPtr usage
https://bugs.webkit.org/show_bug.cgi?id=269322
rdar://119790256
Reviewed by Alan Baradlay.
From the crash trace, we can see that HTMLSelectElement::defaultEventHandler()
holds a CheckedPtr to its RenderMenuList renderer and calls showPopup() on
the renderer. This ends up running JS, which removes the select element from
the DOM and in turns destroys the renderer. The usage is currently safe since
nothing is using the renderer after the JS has run. However, it was tripping
the CheckedPtr assertion.
To address the issue, switch to using WeakPtr for now and add comments to
clarify lifetime. We should consider refactoring this in a follow up though.
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::showPicker):
* Source/WebCore/rendering/RenderMenuList.cpp:
(RenderMenuList::showPopup):
Canonical link: https://commits.webkit.org/274586@main
Canonical link: https://commits.webkit.org/272448.561@safari-7618.1.15.11-branch
Commit: 1268df52cf236119eaa5addf2f13b05b183f19de
https://github.com/WebKit/WebKit/commit/1268df52cf236119eaa5addf2f13b05b183f19de
Author: Sihui Liu <sihui_liu at apple.com>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Source/WebCore/page/Quirks.cpp
Log Message:
-----------
Cherry-pick 31136601a244. rdar://122892811
Null pointer dereference in elementHasClassInClosestAncestors
https://bugs.webkit.org/show_bug.cgi?id=269308
rdar://122892811
Reviewed by Brent Fulgham.
Ensure ancestor is non-null before accessing it.
* Source/WebCore/page/Quirks.cpp:
(WebCore::elementHasClassInClosestAncestors):
Canonical link: https://commits.webkit.org/274575@main
Canonical link: https://commits.webkit.org/272448.562@safari-7618.1.15.11-branch
Commit: e92961170254db5f59491f381aa337c8ec030648
https://github.com/WebKit/WebKit/commit/e92961170254db5f59491f381aa337c8ec030648
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.11.6
Identifier: 272448.563 at safari-7618.1.15.11-branch
Commit: a69612cbde7f2f4efdaf8b04c404cf8cc3837f50
https://github.com/WebKit/WebKit/commit/a69612cbde7f2f4efdaf8b04c404cf8cc3837f50
Author: Youenn Fablet <youennf at gmail.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm
Log Message:
-----------
Cherry-pick 1392a12ad3f1. rdar://122859173
REGRESSION (iOS 17.4 Beta): No incoming video in Teams VA
rdar://122859173
https://bugs.webkit.org/show_bug.cgi?id=269281
Reviewed by Brent Fulgham.
WebRTC applicartions typically do not care about reordering since it hits the latency.
We are thus setting the window size to 0 when AVC is false, which is the case for libwebrtc decoders.
WebCodecs websites that had issues with reordering are using AVC, so should not be broken by this change.
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
(-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):
Canonical link: https://commits.webkit.org/274581@main
Identifier: 272448.564 at safari-7618.1.15.11-branch
Commit: aff4c6a264b8cb6f593c665f228c9016af256164
https://github.com/WebKit/WebKit/commit/aff4c6a264b8cb6f593c665f228c9016af256164
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Apply patch. rdar://122813058
Identifier: 272448.565 at safari-7618.1.15.11-branch
Commit: 085c1a13b20b6c966fde52ff27a4bd7a340f494c
https://github.com/WebKit/WebKit/commit/085c1a13b20b6c966fde52ff27a4bd7a340f494c
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Revert "Apply patch. rdar://122813058"
This reverts commit aff4c6a264b8cb6f593c665f228c9016af256164.
Identifier: 272448.566 at safari-7618.1.15.11-branch
Commit: b1580451625c01ed71414716e7da6fcd71712694
https://github.com/WebKit/WebKit/commit/b1580451625c01ed71414716e7da6fcd71712694
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Apply patch. rdar://122813058
Identifier: 272448.567 at safari-7618.1.15.11-branch
Commit: f3b6ba04a05f4053984d0344074f684e17b7d012
https://github.com/WebKit/WebKit/commit/f3b6ba04a05f4053984d0344074f684e17b7d012
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-16 (Fri, 16 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.11.7
Canonical link: https://commits.webkit.org/272448.568@safari-7618.1.15.11-branch
Commit: 071785c5cb83368311e388d67704083f03ed6e94
https://github.com/WebKit/WebKit/commit/071785c5cb83368311e388d67704083f03ed6e94
Author: Per Arne Vollan <pvollan at apple.com>
Date: 2024-02-16 (Fri, 16 Feb 2024)
Changed paths:
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Log Message:
-----------
Cherry-pick 5add71f66046. rdar://122976577
Catalyst needs tccd access
https://bugs.webkit.org/show_bug.cgi?id=269518
rdar://122976577
Reviewed by Brent Fulgham.
Catalyst needs tccd access in the WebContent process sandbox.
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:
Canonical link: https://commits.webkit.org/274820@main
Canonical link: https://commits.webkit.org/272448.569@safari-7618.1.15.11-branch
Commit: 08de898da6f1176215f03e4a9973867ae55a12dc
https://github.com/WebKit/WebKit/commit/08de898da6f1176215f03e4a9973867ae55a12dc
Author: Russell Epstein <repstein at apple.com>
Date: 2024-02-18 (Sun, 18 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.8
Canonical link: https://commits.webkit.org/272448.570@safari-7618.1.15.11-branch
Commit: f5f18b6e27016b7f92bf28ce5307d6ff457cc4f8
https://github.com/WebKit/WebKit/commit/f5f18b6e27016b7f92bf28ce5307d6ff457cc4f8
Author: Garrett Davidson <garrett_davidson at apple.com>
Date: 2024-02-18 (Sun, 18 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Cherry-pick 1d32f0c70849. rdar://123161979
Add some missing null checks for WebAuthn extension options
rdar://123161979
Reviewed by Brent Fulgham.
Add some missing null checks for WebAuthn extension options.
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForRegisteration):
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion):
Canonical link: https://commits.webkit.org/274952@main
Canonical link: https://commits.webkit.org/272448.571@safari-7618.1.15.11-branch
Commit: e6fc9f8add71e0b5cb0a1c4ee2be98f92b422f19
https://github.com/WebKit/WebKit/commit/e6fc9f8add71e0b5cb0a1c4ee2be98f92b422f19
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-19 (Mon, 19 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.11.9
Identifier: 272448.572 at safari-7618.1.15.11-branch
Commit: 5b41db24ada2893743b7555139c93ddf9038e088
https://github.com/WebKit/WebKit/commit/5b41db24ada2893743b7555139c93ddf9038e088
Author: Dan Robson <dtr_bugzilla at apple.com>
Date: 2024-02-19 (Mon, 19 Feb 2024)
Changed paths:
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
Log Message:
-----------
Apply patch. rdar://123190795
Identifier: 272448.573 at safari-7618.1.15.11-branch
Commit: cc57c48e84d38e502e20939467e9e38b58a2f98c
https://github.com/WebKit/WebKit/commit/cc57c48e84d38e502e20939467e9e38b58a2f98c
Author: Russell Epstein <repstein at apple.com>
Date: 2024-02-26 (Mon, 26 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.10
Canonical link: https://commits.webkit.org/272448.574@safari-7618.1.15.11-branch
Commit: f5f3646a6b67c44fd74f4e839038c4130d060c00
https://github.com/WebKit/WebKit/commit/f5f3646a6b67c44fd74f4e839038c4130d060c00
Author: Russell Epstein <repstein at apple.com>
Date: 2024-02-26 (Mon, 26 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.11
Canonical link: https://commits.webkit.org/272448.575@safari-7618.1.15.11-branch
Commit: e0e62cec982c0a00cd3bb9ffed1526f34512acd8
https://github.com/WebKit/WebKit/commit/e0e62cec982c0a00cd3bb9ffed1526f34512acd8
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.11.12
Identifier: 272448.577 at safari-7618.1.15.11-branch
Commit: dfd64c88b04382227811a1eb91d7779ede4117d2
https://github.com/WebKit/WebKit/commit/dfd64c88b04382227811a1eb91d7779ede4117d2
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Apply patch. rdar://123659147
Identifier: 272448.578 at safari-7618.1.15.11-branch
Commit: e02793f8d20b0b010c9db5fc2a1cb7bd618bfe9c
https://github.com/WebKit/WebKit/commit/e02793f8d20b0b010c9db5fc2a1cb7bd618bfe9c
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Revert "Apply patch. rdar://123659147"
This reverts commit dfd64c88b04382227811a1eb91d7779ede4117d2.
Identifier: 272448.579 at safari-7618.1.15.11-branch
Commit: ecc7415e2db23a135d10ceb99a968cb71791e342
https://github.com/WebKit/WebKit/commit/ecc7415e2db23a135d10ceb99a968cb71791e342
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Cherry-pick dfd64c88b043. rdar://123659147
Identifier: 272448.580 at safari-7618.1.15.11-branch
Commit: 6c385701da60534d81c97538c54f0a98a22175c6
https://github.com/WebKit/WebKit/commit/6c385701da60534d81c97538c54f0a98a22175c6
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Revert "Cherry-pick dfd64c88b043. rdar://123659147"
This reverts commit ecc7415e2db23a135d10ceb99a968cb71791e342.
Identifier: 272448.581 at safari-7618.1.15.11-branch
Commit: 8ed1f25f2371aef61c2aa8d735e1f4fe3da78a64
https://github.com/WebKit/WebKit/commit/8ed1f25f2371aef61c2aa8d735e1f4fe3da78a64
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Apply patch. rdar://123659147
Identifier: 272448.582 at safari-7618.1.15.11-branch
Commit: 1c132286720574c4036aeb74daf9e58c7125a5a9
https://github.com/WebKit/WebKit/commit/1c132286720574c4036aeb74daf9e58c7125a5a9
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Apply patch. rdar://123659147
Identifier: 272448.583 at safari-7618.1.15.11-branch
Compare: https://github.com/WebKit/WebKit/compare/d4124ec0bf9e%5E...1c1322867205
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list