[webkit-changes] [WebKit/WebKit] 815386: Navigator.mediaDevices.getSupportedConstraints mis...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8153861f277e5f0d37a63bf3070945661a11a7e6
      https://github.com/WebKit/WebKit/commit/8153861f277e5f0d37a63bf3070945661a11a7e6
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt
    M LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getSupportedConstraints.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getUserMedia.https-expected.txt
    M Source/WebCore/Modules/mediastream/MediaDevices.cpp
    M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h
    M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
    M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h

  Log Message:
  -----------
  Navigator.mediaDevices.getSupportedConstraints mistakenly reports torch as false.
rdar://124372654
https://bugs.webkit.org/show_bug.cgi?id=270779

Reviewed by Eric Carlson.

As per spec, MediaTrackConstraints member must be true if present.
Each individual source may still or may not support a particular constraint.
We remove RealtimeMediaSourceCenter::m_supportedConstraints and instead make all MediaTrackSupportedConstraints members true by default.
Covered by updated tests.

* LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt:
* LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html:
* LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getSupportedConstraints.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getUserMedia.https-expected.txt:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getSupportedConstraints):
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h:
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::RealtimeMediaSourceCenter):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h:

Canonical link: https://commits.webkit.org/275945@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications