[webkit-changes] [WebKit/WebKit] 9aea47: REGRESSION(275801 at main): Fix issues with Interacti...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9aea4732b3b78dc83e2a101a6df2dd80aed79c05
      https://github.com/WebKit/WebKit/commit/9aea4732b3b78dc83e2a101a6df2dd80aed79c05
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M LayoutTests/interaction-region/content-hint-expected.txt
    M LayoutTests/interaction-region/content-hint.html
    M LayoutTests/interaction-region/overlap-same-group-expected.txt
    M Source/WebCore/page/InteractionRegion.cpp
    M Source/WebCore/rendering/EventRegion.cpp
    M Source/WebCore/rendering/EventRegion.h

  Log Message:
  -----------
  REGRESSION(275801 at main): Fix issues with InteractionRegion generation
https://bugs.webkit.org/show_bug.cgi?id=270799
<rdar://124340905>

Reviewed by Mike Wyrzykowski.

Add the missing nullptr check when looking for photo background images,
fix a logic issue when deciding if we need to generate a shrink wrapped
Path, and go back to modifying the `m_interactionRegions` Vector
directly.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::cachedImageIsPhoto):
(WebCore::interactionRegionForRenderedRegion):
Fix a potential crash when generating InteractionRegions for elements
with background images.

* Source/WebCore/rendering/EventRegion.h:
* Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegionContext::shouldConsolidateInteractionRegion):
(WebCore::EventRegionContext::uniteInteractionRegions):
Keep track of complete InteractionRegion structs instead of just rects
when aggregating by element.
(WebCore::EventRegionContext::copyInteractionRegionsToEventRegion):
(WebCore::EventRegion::appendInteractionRegions):
(WebCore::EventRegionContext::shrinkWrappedInteractionRegions): Deleted.
(WebCore::EventRegionContext::shrinkWrapInteractionRegions):
Switch back to modifying the `m_interactionRegions` Vector directly
during the shrink wrap phase (before copy-ing to the EventRegion).
Fix a logic bug with `canUseSingleRect`.

* LayoutTests/interaction-region/content-hint.html:
* LayoutTests/interaction-region/content-hint-expected.txt:
Add a test case for the crash.
Expectation update without lost InteractionRegion parameters.
* LayoutTests/interaction-region/overlap-same-group-expected.txt:
Re-baseline with the overlap shape regression fixed.

Canonical link: https://commits.webkit.org/275936@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications