[webkit-changes] [WebKit/WebKit] 26d42d: REGRESSION (274626 at main): [ iOS Debug ]media/video...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26d42d0752d10c46cedc862ef032622f47b174e0
      https://github.com/WebKit/WebKit/commit/26d42d0752d10c46cedc862ef032622f47b174e0
  Author: Dana Estra <destra at apple.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M LayoutTests/platform/ios-wk2/TestExpectations
    M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h
    M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm
    M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
    M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h
    M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm

  Log Message:
  -----------
  REGRESSION (274626 at main): [ iOS Debug ]media/video-autoplay.html and media/video-element-other-n amespace-crash.html are constant crashes (270485)
https://bugs.webkit.org/show_bug.cgi?id=270715
rdar://124034839

Reviewed by Jer Noble.

Replacing CompletionHandler with Function to fix crash caused by not calling
the completion handler in all cases. Unskipping tests that were affected.

* LayoutTests/platform/ios-wk2/TestExpectations:
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h:
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm:
(WebCore::VideoPresentationInterfaceAVKit::presentFullscreen):
(WebCore::VideoPresentationInterfaceAVKit::dismissFullscreen):
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h:
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h:
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm:
(WebKit::VideoPresentationInterfaceLMK::presentFullscreen):
(WebKit::VideoPresentationInterfaceLMK::dismissFullscreen):

Canonical link: https://commits.webkit.org/275930@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications