[webkit-changes] [WebKit/WebKit] 472c2a: REGRESSION(272743 at main): WebVTT default styling is...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 472c2a9abc39ccee3c44f9bbe1c2f97cc257780d
      https://github.com/WebKit/WebKit/commit/472c2a9abc39ccee3c44f9bbe1c2f97cc257780d
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    A LayoutTests/media/track/captions-webvtt/inline.vtt
    A LayoutTests/media/track/webvtt-inline-expected.txt
    A LayoutTests/media/track/webvtt-inline.html
    M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css
    M Source/WebCore/css/mediaControls.css

  Log Message:
  -----------
  REGRESSION(272743 at main): WebVTT default styling is broken
https://bugs.webkit.org/show_bug.cgi?id=270783
rdar://124380882

Reviewed by Anne van Kesteren.

272743 at main changed the attribute name for pseudo elements.
The WebVTT styling relied on those names.

* LayoutTests/media/track/captions-webvtt/inline.vtt: Added.
* LayoutTests/media/track/webvtt-inline-expected.txt: Added.
* LayoutTests/media/track/webvtt-inline.html: Added.

Add a test. We had no coverage.

* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
([useragentpart="-webkit-media-text-track-display"]):
(u):
(i):
(.hidden):
([pseudo="-webkit-media-text-track-display"] b): Deleted.
([pseudo="-webkit-media-text-track-display"] u): Deleted.
([pseudo="-webkit-media-text-track-display"] i): Deleted.
([pseudo="-webkit-media-text-track-display"] .hidden): Deleted.
* Source/WebCore/css/mediaControls.css:
([useragentpart="-webkit-media-text-track-display"]):
(u):
(i):
(.hidden):

Also add missing .hidden to this legacy stylesheet.

([pseudo="-webkit-media-text-track-display"] b): Deleted.
([pseudo="-webkit-media-text-track-display"] u): Deleted.
([pseudo="-webkit-media-text-track-display"] i): Deleted.

Canonical link: https://commits.webkit.org/275918@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications