[webkit-changes] [WebKit/WebKit] ad43bc: [visionOS] LinearMediaPlayer does not present audi...

aestes noreply at github.com
Sat Mar 9 13:14:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad43bc6864cfe68b83ec4f3e67444f64e6ffe1ff
      https://github.com/WebKit/WebKit/commit/ad43bc6864cfe68b83ec4f3e67444f64e6ffe1ff
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-03-09 (Sat, 09 Mar 2024)

  Changed paths:
    M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h
    M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm

  Log Message:
  -----------
  [visionOS] LinearMediaPlayer does not present audio and text track options
https://bugs.webkit.org/show_bug.cgi?id=270727
rdar://124308729

Reviewed by Eric Carlson.

When introducing PlaybackSessionInterfaceLMK we neglected to provide implementations for
{audio, legible}MediaSelectionOptionsChanged, resulting in LinearMediaPlayer not presenting these
options in its UI.

Implemented these functions as well as the delegate callbacks to learn when the user changes tracks.

* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h:
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setAudioTrack:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setLegibleTrack:]):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionIndexChanged):
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:

Canonical link: https://commits.webkit.org/275885@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list