[webkit-changes] [WebKit/WebKit] 18e217: Remove legacy ruby implementation

Sat Mar 9 10:04:35 PST 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18e217e0c1998003d85e7596be9e58bb25867328
      https://github.com/WebKit/WebKit/commit/18e217e0c1998003d85e7596be9e58bb25867328
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-09 (Sat, 09 Mar 2024)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/editing/Editing.cpp
    M Source/WebCore/editing/TextIterator.cpp
    M Source/WebCore/html/RubyElement.cpp
    M Source/WebCore/html/RubyElement.h
    M Source/WebCore/html/RubyTextElement.cpp
    M Source/WebCore/html/track/WebVTTElement.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
    M Source/WebCore/platform/ios/SelectionGeometry.cpp
    M Source/WebCore/platform/ios/SelectionGeometry.h
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/LegacyInlineTextBox.cpp
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/LegacyLineLayout.h
    M Source/WebCore/rendering/LegacyRootInlineBox.cpp
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlock.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderElementInlines.h
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderLineBreak.cpp
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderObject.h
    R Source/WebCore/rendering/RenderRuby.cpp
    R Source/WebCore/rendering/RenderRuby.h
    R Source/WebCore/rendering/RenderRubyBase.cpp
    R Source/WebCore/rendering/RenderRubyBase.h
    R Source/WebCore/rendering/RenderRubyRun.cpp
    R Source/WebCore/rendering/RenderRubyRun.h
    R Source/WebCore/rendering/RenderRubyText.cpp
    R Source/WebCore/rendering/RenderRubyText.h
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/rendering/TextDecorationPainter.cpp
    M Source/WebCore/rendering/line/BreakingContext.h
    M Source/WebCore/rendering/line/LineWidth.cpp
    M Source/WebCore/rendering/line/LineWidth.h
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h

  Log Message:
  -----------
  Remove legacy ruby implementation
https://bugs.webkit.org/show_bug.cgi?id=270741
rdar://124325661

Reviewed by Alan Baradlay.

Remove dead code.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* Source/WebCore/editing/Editing.cpp:
(WebCore::isBlock):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
* Source/WebCore/html/RubyElement.cpp:
(WebCore::RubyElement::createElementRenderer): Deleted.
* Source/WebCore/html/RubyElement.h:
* Source/WebCore/html/RubyTextElement.cpp:
(WebCore::RubyTextElement::createElementRenderer):
* Source/WebCore/html/track/WebVTTElement.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:
* Source/WebCore/platform/ios/SelectionGeometry.cpp:
(WebCore::SelectionGeometry::SelectionGeometry):
(WebCore::operator<<):
* Source/WebCore/platform/ios/SelectionGeometry.h:
(WebCore::SelectionGeometry::isInFixedPosition const):
(WebCore::SelectionGeometry::isRubyText const): Deleted.
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::placeChildInlineBoxesInBlockDirection):
(WebCore::LegacyInlineFlowBox::computeOverAnnotationAdjustment const):
(WebCore::LegacyInlineFlowBox::computeUnderAnnotationAdjustment const):
* Source/WebCore/rendering/LegacyInlineTextBox.cpp:
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::computeExpansionForJustifiedText):
(WebCore::expansionBehaviorForInlineTextBox):
(WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment):
(WebCore::LegacyLineLayout::layoutLineBoxes):
(WebCore::LegacyLineLayout::setMarginsForRubyRun): Deleted.
(WebCore::LegacyLineLayout::updateRubyForJustifiedText): Deleted.
* Source/WebCore/rendering/LegacyLineLayout.h:
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::selectionTop const):
(WebCore::LegacyRootInlineBox::selectionBottom const):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::baselinePosition const):
(WebCore::RenderBlock::firstLineBaseline const):
(WebCore::RenderBlock::lastLineBaseline const):
(WebCore::RenderBlock::inlineBlockBaseline const):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns const):
(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::lastLineBaseline const):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInFragment const):
* Source/WebCore/rendering/RenderElementInlines.h:
(WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const):
(WebCore::RenderElement::shouldApplySizeOrStyleContainment const):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::collectSelectionGeometries):
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionGeometries):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::collectSelectionGeometriesInternal):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isRenderRubyAsInline const): Deleted.
(WebCore::RenderObject::isRenderRubyAsBlock const): Deleted.
(WebCore::RenderObject::isRenderRubyBase const): Deleted.
(WebCore::RenderObject::isRenderRubyRun const): Deleted.
(WebCore::RenderObject::isRenderRubyText const): Deleted.
* Source/WebCore/rendering/RenderRuby.cpp: Removed.
* Source/WebCore/rendering/RenderRuby.h: Removed.
* Source/WebCore/rendering/RenderRubyBase.cpp: Removed.
* Source/WebCore/rendering/RenderRubyBase.h: Removed.
* Source/WebCore/rendering/RenderRubyRun.cpp: Removed.
* Source/WebCore/rendering/RenderRubyRun.h: Removed.
* Source/WebCore/rendering/RenderRubyText.cpp: Removed.
* Source/WebCore/rendering/RenderRubyText.h: Removed.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionGeometries):
(WebCore::RenderText::emphasisMarkExistsAndIsAbove):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::collectStylesForRenderer):
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleReplaced):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* Source/WebCore/rendering/line/LineWidth.cpp:
(WebCore::LineWidth::updateLineDimension):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::applyOverhang): Deleted.
* Source/WebCore/rendering/line/LineWidth.h:
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachInternal):
(WebCore::RenderTreeBuilder::detach):
(WebCore::RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers):
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::canDropAnonymousBlock):
(WebCore::RenderTreeBuilder::Block::removeLeftoverAnonymousBlock):
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::supportsFirstLetter):
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
(WebCore::getParentOfFirstLineBox):
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::findRubyRunParent): Deleted.
(WebCore::isRubyChildForNormalRemoval): Deleted.
(WebCore::RenderTreeBuilder::Ruby::moveInlineChildren): Deleted.
(WebCore::RenderTreeBuilder::Ruby::moveBlockChildren): Deleted.
(WebCore::RenderTreeBuilder::Ruby::moveChildren): Deleted.
(WebCore::RenderTreeBuilder::Ruby::moveChildrenInternal): Deleted.
(WebCore::RenderTreeBuilder::Ruby::attach): Deleted.
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForChild): Deleted.
(WebCore::RenderTreeBuilder::Ruby::rubyBaseSafe): Deleted.
(WebCore::RenderTreeBuilder::Ruby::detach): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h:

Canonical link: https://commits.webkit.org/275879@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications