[webkit-changes] [WebKit/WebKit] 93c3eb: AX: CSS content property replacement text ignored ...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93c3eb8ac99a6b6e3894deaf14e5d38304898b48
      https://github.com/WebKit/WebKit/commit/93c3eb8ac99a6b6e3894deaf14e5d38304898b48
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M LayoutTests/accessibility/mac/alt-for-css-content-expected.txt
    M LayoutTests/accessibility/mac/alt-for-css-content.html
    M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content.html
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp

  Log Message:
  -----------
  AX: CSS content property replacement text ignored when it is the empty string
https://bugs.webkit.org/show_bug.cgi?id=270377
rdar://123919677

Reviewed by Antoine Quint.

This issue came to light as part of the <input type=checkbox switch>
demo, but is more universally applicable as shown in the tests.

While here, also cleanup some of the code as the render objects
involved cannot become null.

New web-platform-tests tests are exported:
https://github.com/web-platform-tests/wpt/pull/44971

* LayoutTests/accessibility/mac/alt-for-css-content-expected.txt:
* LayoutTests/accessibility/mac/alt-for-css-content.html:
* LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content.html:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement const):

Canonical link: https://commits.webkit.org/275872@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications