[webkit-changes] [WebKit/WebKit] acfa63: Add disassembleBase64 function to jsc cli

Keith Miller noreply at github.com
Fri Mar 8 13:14:58 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acfa63bc90bc133dab16f9512a77fe159adcb5b7
      https://github.com/WebKit/WebKit/commit/acfa63bc90bc133dab16f9512a77fe159adcb5b7
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/JavaScriptCore/disassembler/Disassembler.h
    M Source/JavaScriptCore/jsc.cpp

  Log Message:
  -----------
  Add disassembleBase64 function to jsc cli
https://bugs.webkit.org/show_bug.cgi?id=270707
rdar://124288714

Reviewed by Justin Michaud.

Sometimes we get crash reports that have some assembly around the crashing
JIT pc. This code is encoded in base64 but unfortunately `btoa` gives the
code back with the wrong endianness, I think anyway. Rather than figure out
how to flip the endianness I just decided to roll everything into one function.

* Source/JavaScriptCore/disassembler/Disassembler.h:
* Source/JavaScriptCore/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
* Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::data const):

Canonical link: https://commits.webkit.org/275853@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list