[webkit-changes] [WebKit/WebKit] 0d1d56: [UnifiedPDF] Fix coordinate space for accessibility.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d1d56d4da989bb82028ad08c8d392dc2b3ab51e
      https://github.com/WebKit/WebKit/commit/0d1d56d4da989bb82028ad08c8d392dc2b3ab51e
  Author: Elina <elina.ding at apple.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h
    M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm

  Log Message:
  -----------
  [UnifiedPDF] Fix coordinate space for accessibility.

Reviewed by Abrar Rahman Protyasha.

- Fix VO cursor position does not match the focused element in unified pdf.
There are 2 parts of this change. One in pdfKit and one in webKit
- Update the plugin in WKAccessibilityDocumentObject to UnifiedPDFPlugin
- Remove extra functions
- Add new accessibility support api.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::PDFPluginBase):
(WebKit::PDFPluginBase::convertFromPDFViewToRootView const): Deleted.
(WebKit::PDFPluginBase::convertFromPDFViewToScreenForAccessibility const): Deleted.
(WebKit::PDFPluginBase::convertFromRootViewToPDFView const): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::UnifiedPDFPlugin):
(WebKit::UnifiedPDFPlugin::accessibilityScrollToPage):
(WebKit::UnifiedPDFPlugin::convertFromPDFPageToScreenForAccessibility const):
(WebKit::UnifiedPDFPlugin::accessibilityHitTestIntPoint const):
* Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h:
* Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm:
(-[WKAccessibilityPDFDocumentObject setPDFPlugin:]):
(-[WKAccessibilityPDFDocumentObject accessibilityFocusedUIElement]):
(-[WKAccessibilityPDFDocumentObject accessibilityWindow]):
(-[WKAccessibilityPDFDocumentObject accessibilityTopLevelUIElement]):
(-[WKAccessibilityPDFDocumentObject accessibilityVisibleChildren]):
(-[WKAccessibilityPDFDocumentObject accessibilitySubrole]):
(-[WKAccessibilityPDFDocumentObject accessibilityFrame]):
(-[WKAccessibilityPDFDocumentObject accessibilityParent]):
(-[WKAccessibilityPDFDocumentObject accessibilityAttributeValue:]):
(-[WKAccessibilityPDFDocumentObject accessibilityArrayAttributeCount:]):
(-[WKAccessibilityPDFDocumentObject accessibilityChildren]):
(-[WKAccessibilityPDFDocumentObject convertFromPDFPageToScreenForAccessibility:pageIndex:]):
(-[WKAccessibilityPDFDocumentObject accessibilityHitTest:]):
(-[WKAccessibilityPDFDocumentObject gotoDestination:]):
(-[WKAccessibilityPDFDocumentObject parent]): Deleted.

[UnifiedPDF] Fix coordinate space for accessibility https://bugs.webkit.org/show_bug.cgi?id=269956 rdar://123459892

Reviewed by Abrar Rahman Protyasha.

- Fix VO cursor position does not match the focused element in unified pdf.
There are 2 parts of this change. One in pdfKit and one in webKit
- Update the plugin in WKAccessibilityDocumentObject to UnifiedPDFPlugin
- Remove extra functions
- Add new accessibility support api

Canonical link: https://commits.webkit.org/275848@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications