[webkit-changes] [WebKit/WebKit] aaa2de: Cherry-pick 274706 at main (9a071fa681c3). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: aaa2de95fee05bf4be501f5559d45512cf9cb93a
      https://github.com/WebKit/WebKit/commit/aaa2de95fee05bf4be501f5559d45512cf9cb93a
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  Cherry-pick 274706 at main (9a071fa681c3). https://bugs.webkit.org/show_bug.cgi?id=269354

    [GStreamer] webrtc/video-lowercase-media-subtype.html times out
    https://bugs.webkit.org/show_bug.cgi?id=269354

    Reviewed by Xabier Rodriguez-Calvar.

    The last issue with that test was that the transceiver direction (recvonly) of the receiver was
    copied over to the sending PeerConnection, thus breaking negotiation, preventing the sender to start
    streaming.

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
    (WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):
    * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

    Canonical link: https://commits.webkit.org/274706@main


  Commit: 10d3e3ea3aa392556688cd532085bfff60aa0acd
      https://github.com/WebKit/WebKit/commit/10d3e3ea3aa392556688cd532085bfff60aa0acd
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h
    M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp
    M Source/WebKit/UIProcess/API/wpe/WPEWebView.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp

  Log Message:
  -----------
  Cherry-pick 274710 at main (1512e48affb3). https://bugs.webkit.org/show_bug.cgi?id=269353

    [WPE] Web Platform: implement WebPageProxy::callAfterNextPresentationUpdate
    https://bugs.webkit.org/show_bug.cgi?id=269353

    Reviewed by Adrian Perez de Castro.

    With the old API we just use a 0 seconds timer, but with the new API we
    can use the buffer-renderer signal of WPEView to actually call the
    callback after the next buffer is rendered. This will hopefully reduce
    the flakiness of ref tests.

    * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
    (WebKit::PageClientImpl::callAfterNextPresentationUpdate):
    * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:
    * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
    (WKWPE::View::callAfterNextPresentationUpdate):
    * Source/WebKit/UIProcess/API/wpe/WPEWebView.h:
    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp:
    (WebKit::WebPageProxy::callAfterNextPresentationUpdate):

    Canonical link: https://commits.webkit.org/274710@main


  Commit: 0032643ddb04053db08c73517adf7ae6664fbf5f
      https://github.com/WebKit/WebKit/commit/0032643ddb04053db08c73517adf7ae6664fbf5f
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/glib/UserAgentQuirks.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

  Log Message:
  -----------
  Cherry-pick 275835 at main (1a9883acbbb0). https://bugs.webkit.org/show_bug.cgi?id=270438

    Atlassian Confluence blocks Epiphany's user agent
    https://bugs.webkit.org/show_bug.cgi?id=270438

    Reviewed by Philippe Normand.

    * Source/WebCore/platform/glib/UserAgentQuirks.cpp:
    (WebCore::urlRequiresMacintoshPlatform):
    * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
    (TestWebKitAPI::TEST):

    Canonical link: https://commits.webkit.org/275835@main


  Commit: a1717d6dc40464663ea845fd58d34b72b5aea62f
      https://github.com/WebKit/WebKit/commit/a1717d6dc40464663ea845fd58d34b72b5aea62f
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/JavaScriptCore/llint/LowLevelInterpreter.asm

  Log Message:
  -----------
  Cherry-pick 274796 at main (be51d0725a2c). https://bugs.webkit.org/show_bug.cgi?id=269534

    [JSC] Use offlineasm globl to ensure that all entries have alt_entry
    https://bugs.webkit.org/show_bug.cgi?id=269534
    rdar://122525586

    Reviewed by Justin Michaud.

    We found that vmEntryToCSSJIT and vmEntryToCSSJITAfter are not having alt_entry properly since it is not using offlineasm globl.
    This allowed LLInt code shuffled by linkers when alt_entry is used, which breaks many assumptions. This patch fixes it.

    * Source/JavaScriptCore/llint/LowLevelInterpreter.asm:

    Canonical link: https://commits.webkit.org/274796@main


  Commit: bdd790d01712ed52446a7cfc3d97cf7ebed381fc
      https://github.com/WebKit/WebKit/commit/bdd790d01712ed52446a7cfc3d97cf7ebed381fc
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  Cherry-pick 275786 at main (755898f07a51). https://bugs.webkit.org/show_bug.cgi?id=260796

    [GStreamer] Crash after 10 seconds on watchdog thread due to deadlock deep inside GStreamer
    https://bugs.webkit.org/show_bug.cgi?id=260796

    Reviewed by Xabier Rodriguez-Calvar.

    Disable on-disk buffering for looping videos, due to high risks of deadlocking. The whole on-disk
    buffering feature is doomed to disappear eventually anyway, since decodebin3/playbin3 have regressed
    in that regard (by design).

    * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    (WebCore::MediaPlayerPrivateGStreamer::updateDownloadBufferingFlag):

    Canonical link: https://commits.webkit.org/275786@main


  Commit: 879210cb1b1fa15cff108bb3b2c4cdd5c1f81757
      https://github.com/WebKit/WebKit/commit/879210cb1b1fa15cff108bb3b2c4cdd5c1f81757
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp

  Log Message:
  -----------
  Cherry-pick 274456 at main (8cf5489bfce0). https://bugs.webkit.org/show_bug.cgi?id=269056

    [GStreamer] Harness: Basic GstStream handling
    https://bugs.webkit.org/show_bug.cgi?id=269056

    Reviewed by Xabier Rodriguez-Calvar.

    When fetching the Stream caps, first check if there is an associated GstStream, because its caps
    might be more accurate than the ones sticked on the corresponding pad.

    * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
    (WebCore::GStreamerElementHarness::Stream::outputCaps):
    (WebCore::GStreamerElementHarness::Stream::sinkEvent):

    Canonical link: https://commits.webkit.org/274456@main


  Commit: efeb81d47e0271b1036b332dc9b1301b63f59f88
      https://github.com/WebKit/WebKit/commit/efeb81d47e0271b1036b332dc9b1301b63f59f88
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
    M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h

  Log Message:
  -----------
  Cherry-pick 275032 at main (e653f5a19d03). https://bugs.webkit.org/show_bug.cgi?id=264824

    [GStreamer] Crash after 10 seconds on watchdog thread do to loop when destroying ~ImageDecoderGStreamerSample
    https://bugs.webkit.org/show_bug.cgi?id=264824

    Reviewed by Xabier Rodriguez-Calvar.

    The WebProcess was deadlocking at shutdown when the disposal of the element harness of the image
    decoder was triggering disposal of chained harnesses, within the same thread, through the
    pad-removed signal emission. The proposed solution is to use a recursive mutex for active pipelines
    storage protection.

    This patch also fixes a few more leaks in ImageDecoder and the element harness.

    * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
    (WebCore::deinitializeGStreamer):
    * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
    (WebCore::teardownGStreamerImageDecoders):
    (WebCore::ImageDecoderGStreamer::create):
    (WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
    (WebCore::ImageDecoderGStreamer::tearDown):
    (WebCore::ImageDecoderGStreamer::pushEncodedData):
    * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h:
    * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
    (WebCore::GStreamerElementHarness::GStreamerElementHarness):
    (WebCore::GStreamerElementHarness::~GStreamerElementHarness):
    (WebCore::GStreamerElementHarness::Stream::Stream):
    (WebCore::GStreamerElementHarness::Stream::~Stream):
    (WebCore::GStreamerElementHarness::Stream::sinkEvent):
    (WebCore::GStreamerElementHarness::srcEvent):
    * Source/WebCore/platform/gstreamer/GStreamerElementHarness.h:

    Canonical link: https://commits.webkit.org/275032@main


  Commit: 3ca1c7594402f8cc77169577b49260fae70a6430
      https://github.com/WebKit/WebKit/commit/3ca1c7594402f8cc77169577b49260fae70a6430
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  -----------
  Cherry-pick 274811 at main (592d7746b7a9). https://bugs.webkit.org/show_bug.cgi?id=268977

    [GStreamer] De-initialize only if leaks tracer is active
    https://bugs.webkit.org/show_bug.cgi?id=268977

    Reviewed by Xabier Rodriguez-Calvar.

    The `gst_deinit()` call is useful only if the leaks tracer is active. Otherwise resources will be
    freed anyway when the WebProcess terminates.

    * Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
    (WTF::adoptGRef):
    (WTF::refGPtr<GstTracer>):
    (WTF::derefGPtr<GstTracer>):
    * Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:
    * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
    (WebCore::deinitializeGStreamer):

    Canonical link: https://commits.webkit.org/274811@main


Compare: https://github.com/WebKit/WebKit/compare/c57c891428ee...3ca1c7594402

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications