[webkit-changes] [WebKit/WebKit] bd1508: AX: Loading progress percentage used for WebAre ti...

AndresGonzalezApple noreply at github.com
Fri Mar 8 07:15:54 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd1508d26370ab1fc6096e40d88b1e6a82436a26
      https://github.com/WebKit/WebKit/commit/bd1508d26370ab1fc6096e40d88b1e6a82436a26
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h
    M Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm

  Log Message:
  -----------
  AX: Loading progress percentage used for WebAre title is not localized.
https://bugs.webkit.org/show_bug.cgi?id=270670
<rdar://problem/124238656>

Reviewed by Tyler Wilcock.

Added COCOA helper function localizedPercentage and modified AXProcessingPage to return the entire localized string including the percentage.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::reportLoadingProgress):
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::AXProcessingPage): Deleted.
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::localizedPercentage):
(WebCore::AXProcessingPage):

Canonical link: https://commits.webkit.org/275834@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list