[webkit-changes] [WebKit/WebKit] bfe017: [JSC] Decode local indices at runtime in WASM in-p...

[David Degazio]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bfe0170022760b1772ed3378d20af384ca44b23d
      https://github.com/WebKit/WebKit/commit/bfe0170022760b1772ed3378d20af384ca44b23d
  Author: David Degazio <d_degazio at apple.com>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    A JSTests/microbenchmarks/local-get-set-tee.wasm
    M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
    M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp

  Log Message:
  -----------
  [JSC] Decode local indices at runtime in WASM in-place interpreter
https://bugs.webkit.org/show_bug.cgi?id=270376
rdar://123720682

Reviewed by Justin Michaud and Yusuke Suzuki.

Removes metadata generation for local.get, local.set, and local.tee
from the WASM in-place interpreter. Instead, local indices for these
instructions are decoded at runtime. Since most local indices are
small, this actually saves us time - the added microbenchmark runs
3% faster with this change. More importantly, this saves on memory,
eliminating metadata for the most common WASM instructions.

* JSTests/microbenchmarks/local-get-set-tee.wasm: Added.
* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::getLocal):
(JSC::Wasm::IPIntGenerator::setLocal):

Canonical link: https://commits.webkit.org/275815@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications