[webkit-changes] [WebKit/WebKit] dc5a91: [WebGPU] createView on a rgba16float canvas may crash

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc5a9185627c7904742367325f6e3a1f6ab94a1e
      https://github.com/WebKit/WebKit/commit/dc5a9185627c7904742367325f6e3a1f6ab94a1e
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] createView on a rgba16float canvas may crash
https://bugs.webkit.org/show_bug.cgi?id=270559
<rdar://problem/124117002>

Reviewed by Alex Christensen.

We were setting the pixel format to bgra8unorm but leaving
the WGPU texture format as rgba16float.

That is incorrect.

Revert of additional validation which is not needed to fix
the crash.

* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::textureViewFormatCompatible):
(WebGPU::Device::errorValidatingTextureCreation):
(WebGPU::Texture::createView):
(WebGPU::textureViewFormatCompatible): Deleted.

Canonical link: https://commits.webkit.org/275803@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications